Skip to content

add scuttle exceptions for JSON and Date#18989

Merged
pedronfigueiredo merged 2 commits intodevelopfrom
add-json-date-to-scuttle-exceptions
May 3, 2023
Merged

add scuttle exceptions for JSON and Date#18989
pedronfigueiredo merged 2 commits intodevelopfrom
add-json-date-to-scuttle-exceptions

Conversation

@pedronfigueiredo
Copy link
Copy Markdown
Contributor

@pedronfigueiredo pedronfigueiredo commented May 3, 2023 •
edited
Loading

Explanation

As suggested in this comment, this PR makes changes to the build system atomically for increased visibility for the changelog.

Screenshots of before the changes

Screenshot 2023-05-03 at 17 09 25

Screenshot 2023-05-03 at 17 02 26

@pedronfigueiredo pedronfigueiredo self-assigned this May 3, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 3, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@pedronfigueiredo pedronfigueiredo force-pushed the add-json-date-to-scuttle-exceptions branch from 5f739f2 to c898f22 Compare May 3, 2023 13:18
@pedronfigueiredo pedronfigueiredo marked this pull request as ready for review May 3, 2023 13:18
@pedronfigueiredo pedronfigueiredo requested review from a team and kumavis as code owners May 3, 2023 13:18
@pedronfigueiredo pedronfigueiredo requested a review from micaelae May 3, 2023 13:18
brad-decker
brad-decker previously approved these changes May 3, 2023
View reviewed changes
@brad-decker brad-decker mentioned this pull request May 3, 2023
Merged
@pedronfigueiredo pedronfigueiredo force-pushed the add-json-date-to-scuttle-exceptions branch from c898f22 to c21d7df Compare May 3, 2023 13:46
DDDDDanica
DDDDDanica previously approved these changes May 3, 2023
View reviewed changes
@pedronfigueiredo pedronfigueiredo force-pushed the add-json-date-to-scuttle-exceptions branch 2 times, most recently from 8c4bed6 to b04ca2f Compare May 3, 2023 14:09
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 3, 2023

Builds ready [b04ca2f]
Page Load Metrics (1667 ± 56 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint951881302512
domContentLoaded14471907165811857
load14601929166711856
domInteractive14471907165811857
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 14 bytes
  • ui: 0 bytes
  • common: 0 bytes

Gudahtt
Gudahtt reviewed May 3, 2023
View reviewed changes
@pedronfigueiredo pedronfigueiredo dismissed stale reviews from DDDDDanica and brad-decker via 72af037 May 3, 2023 15:08
@pedronfigueiredo pedronfigueiredo force-pushed the add-json-date-to-scuttle-exceptions branch from b04ca2f to 72af037 Compare May 3, 2023 15:08
Gudahtt
Gudahtt approved these changes May 3, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pedronfigueiredo pedronfigueiredo force-pushed the add-json-date-to-scuttle-exceptions branch from 72af037 to 30366ae Compare May 3, 2023 15:43
@pedronfigueiredo pedronfigueiredo merged commit a356c40 into develop May 3, 2023
@pedronfigueiredo pedronfigueiredo deleted the add-json-date-to-scuttle-exceptions branch May 3, 2023 16:07
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2023
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 3, 2023

Builds ready [30366ae]
Page Load Metrics (1597 ± 44 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint983701376531
domContentLoaded1440187715579144
load1444187715979144
domInteractive1440187715579144
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 14 bytes
  • ui: 0 bytes
  • common: 0 bytes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@DDDDDanica DDDDDanica DDDDDanica approved these changes

@kumavis kumavis Awaiting requested review from kumavis kumavis is a code owner

@micaelae micaelae Awaiting requested review from micaelae micaelae is a code owner automatically assigned from MetaMask/extension-devs

+1 more reviewer

@brad-decker brad-decker brad-decker left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@pedronfigueiredo pedronfigueiredo

Labels

team-extension-platform Extension Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pedronfigueiredo @metamaskbot @Gudahtt @brad-decker @DDDDDanica