Skip to content

Introduce action metrics for mv3 service worker restart#18346

Merged
pedronfigueiredo merged 22 commits intodevelopfrom
action-metrics-4
Mar 31, 2023
Merged

Introduce action metrics for mv3 service worker restart#18346
pedronfigueiredo merged 22 commits intodevelopfrom
action-metrics-4

Conversation

@pedronfigueiredo
Copy link
Copy Markdown
Contributor

@pedronfigueiredo pedronfigueiredo commented Mar 28, 2023 •
edited
Loading

Explanation

Introduce action metrics for logging:

  • List of actions processed during a service worker restart (action queue processing)
  • Time between service worker restarts.

This PR does not include any tests.

Automated Testing Steps

  1. Copy the test on this PR https://github.com/MetaMask/metamask-extension/pull/18347/files
  2. Run yarn build:test:dev:mv3
  3. On a separate window, run IN_TEST=true yarn test:e2e:single test/e2e/mv3/service-worker-restart.spec.js --browser=chrome --leave-running

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@pedronfigueiredo pedronfigueiredo self-assigned this Mar 28, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 28, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@pedronfigueiredo pedronfigueiredo mentioned this pull request Mar 28, 2023
Merged
@pedronfigueiredo pedronfigueiredo force-pushed the action-metrics-4 branch 3 times, most recently from 310e0a5 to 12c692c Compare March 29, 2023 09:53
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 29, 2023

Builds ready [7051f6f]
Page Load Metrics (1622 ± 53 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint93157118157
domContentLoaded1437182016109948
load14371832162211053
domInteractive1437182016109948
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 559 bytes
  • ui: 532 bytes
  • common: 86 bytes

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 29, 2023

Builds ready [f4163e3]
Page Load Metrics (1764 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint98155122178
domContentLoaded15821957173910953
load15932026176412761
domInteractive15821957173910953
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 559 bytes
  • ui: 532 bytes
  • common: 86 bytes

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2023 •
edited
Loading

Codecov Report

Merging #18346 (0031a9c) into develop (c261817) will increase coverage by 0.00%.
The diff coverage is 85.71%.

@@           Coverage Diff            @@
##           develop   #18346   +/-   ##
========================================
  Coverage    64.78%   64.78%           
========================================
  Files          926      927    +1     
  Lines        35670    35691   +21     
  Branches      9159     9162    +3     
========================================
+ Hits         23106    23121   +15     
- Misses       12564    12570    +6
Impacted Files Coverage Δ
app/scripts/controllers/app-state.js 40.74% <0.00%> (-0.77%) ⬇️
shared/constants/metametrics.js 100.00% <ø> (ø)
app/scripts/metamask-controller.js 61.93% <87.50%> (-0.19%) ⬇️
shared/constants/test-flags.js 100.00% <100.00%> (ø)
ui/store/action-queue/index.ts 93.06% <100.00%> (+0.41%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 29, 2023

Builds ready [8b0a7d2]
Page Load Metrics (1827 ± 73 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint982761363617
domContentLoaded15972227182415474
load15972227182715373
domInteractive15972227182315574
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 559 bytes
  • ui: 532 bytes
  • common: 86 bytes

PeterYinusa
PeterYinusa reviewed Mar 29, 2023
View reviewed changes
PeterYinusa
PeterYinusa reviewed Mar 29, 2023
View reviewed changes
PeterYinusa
PeterYinusa reviewed Mar 29, 2023
View reviewed changes
PeterYinusa
PeterYinusa reviewed Mar 29, 2023
View reviewed changes
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 29, 2023

Builds ready [4d4659f]
Page Load Metrics (1570 ± 59 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint91134110136
domContentLoaded13551841156012259
load13731841157012459
domInteractive13551841156012259
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 559 bytes
  • ui: 532 bytes
  • common: 86 bytes

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 29, 2023

Builds ready [c01d5fd]
Page Load Metrics (1587 ± 27 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint921871112010
domContentLoaded1444169015676230
load1511169015875527
domInteractive1444169015676230
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 559 bytes
  • ui: 505 bytes
  • common: 86 bytes

brad-decker
brad-decker previously approved these changes Mar 29, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question

brad-decker
brad-decker previously approved these changes Mar 29, 2023
View reviewed changes
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 30, 2023

Builds ready [fd5e81b]
Page Load Metrics (1568 ± 27 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint88132106126
domContentLoaded1475167215585627
load1475169215685727
domInteractive1474167215585627
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 559 bytes
  • ui: 437 bytes
  • common: 86 bytes

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 30, 2023

Builds ready [62d5396]
Page Load Metrics (1537 ± 44 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint92148110178
domContentLoaded1352173215129445
load1388173315379244
domInteractive1352173215129445
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1151 bytes
  • ui: 437 bytes
  • common: 86 bytes

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 31, 2023

Builds ready [0031a9c]
Page Load Metrics (2054 ± 150 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint953111755828
domContentLoaded135825022051310149
load135925032054311150
domInteractive135825022051309149
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1151 bytes
  • ui: 437 bytes
  • common: 86 bytes

@pedronfigueiredo pedronfigueiredo merged commit fbd68d4 into develop Mar 31, 2023
@pedronfigueiredo pedronfigueiredo deleted the action-metrics-4 branch March 31, 2023 13:22
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kumavis kumavis Awaiting requested review from kumavis

3 more reviewers

@danjm danjm danjm approved these changes

@PeterYinusa PeterYinusa PeterYinusa approved these changes

@brad-decker brad-decker brad-decker left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@pedronfigueiredo pedronfigueiredo

Labels

team-extension-platform Extension Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Service Worker metrics Action Queue metrics

5 participants

@pedronfigueiredo @metamaskbot @brad-decker @danjm @PeterYinusa