Migration 51: ensure chainId is set in state for default/infura providers#10170
Merged
Migration 51: ensure chainId is set in state for default/infura providers#10170
Conversation
…ate for all infura/default networks
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [be702d8]
Page Load Metrics (887 ± 63 ms)
|
rekmarks
requested changes
Jan 11, 2021
Member
rekmarks
left a comment
There was a problem hiding this comment.
Looks good. One nit and one question.
Contributor
Author
Collaborator
Builds ready [f3f4d78]
Page Load Metrics (819 ± 64 ms)
|
Collaborator
Builds ready [45b2280]
Page Load Metrics (636 ± 48 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, some users are experiencing a disabled swaps buttom on the home screen, in v8.1.11
This can be recreated by:
This is because
chainIdwasn't set to a default in the network controller provider state until #9999 shipped in v8.1.8. However, it will get set whenever a user switches network. Users that first installed metamask prior to v8.1.8 but have not switched networks away from mainnet since installation will not have achainIdin their network controller provider state. With the changes in #10155, this will cause swaps to be disabled as their chainId in state will not match the hard-coded mainnet chainIdThis PR fixes that issue by ensure that the provider data in state is updated to include the correct chainId for all default / infura networks (i.e. those for which we have hard coded chainIds).
This will also prevent similar errors from happening if/when we add any future code changes that rely on comparison of chainId in state to hard coded chainIds
Note: the hard coded chainIds can be found in
controllers/network/enums.js