Disable swaps based on chainId, instead of network id#10155
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Gudahtt
reviewed
Jan 7, 2021
Gudahtt
requested changes
Jan 7, 2021
Member
Gudahtt
left a comment
There was a problem hiding this comment.
See here for details: https://github.com/MetaMask/metamask-extension/pull/10155/files#r553418229
danjm
commented
Jan 7, 2021
4d3fd72 to
8cb244e
Compare
8cb244e to
30fdf69
Compare
Collaborator
Builds ready [30fdf69]
Page Load Metrics (567 ± 54 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the swaps button is disabled when the current network id is not the mainnet network id. There are, however, some networks that have the same network id as ethereum mainnet. Ethereum Classic is a prominent example. This means that users connected to the ethereum classic network can access and use the swaps feature.
Unfortunately doing so would just cause them to lose funds, as there is no swaps contract on networks other than mainnet.
This PR prevents this problem by disabling access to swaps based on chainId instead of networkId. In addition, it prevents accessing swaps routes entirely when not on mainnet.