Skip to content

feat: Card#923

Merged
kirillzyusko merged 5 commits into
MetaMask:mainfrom
kirillzyusko:feat/card
Feb 20, 2026
Merged

feat: Card#923
kirillzyusko merged 5 commits into
MetaMask:mainfrom
kirillzyusko:feat/card

Conversation

@kirillzyusko

@kirillzyusko kirillzyusko commented Feb 19, 2026

Copy link
Copy Markdown
Collaborator

Description

Added Card component.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/DSYS-291

Manual testing steps

  1. Open StoryBook app
  2. Test Card component

Screenshots/Recordings

Before

After

image

Pre-merge author checklist

  • I've followed MetaMask Contributor Docs
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Mostly additive UI component work with Storybook/docs/tests; low blast radius aside from the new public export surface in components/index.ts.

Overview
Adds a new Card component to design-system-react-native with default border/background styling, optional onPress behavior (renders as TouchableOpacity), and style customization via twClassName, style, and touchableOpacityProps.

Exports Card/CardProps from the components index, adds Storybook stories (and updates auto-generated storybook.requires.js) plus unit tests and a README.md for usage/props documentation.

Written by Cursor Bugbot for commit dc1e125. This will update automatically on new commits. Configure here.

@kirillzyusko kirillzyusko self-assigned this Feb 19, 2026
@kirillzyusko kirillzyusko marked this pull request as ready for review February 19, 2026 16:02
@kirillzyusko kirillzyusko requested a review from a team as a code owner February 19, 2026 16:02
Comment thread packages/design-system-react-native/src/components/Card/index.ts
@kirillzyusko kirillzyusko enabled auto-merge (squash) February 20, 2026 16:19
@kirillzyusko kirillzyusko merged commit d4c022c into MetaMask:main Feb 20, 2026
80 checks passed

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

export type { BoxProps, BoxSpacing } from './Box';

export { Card } from './Card';
export type { CardProps } from './Card';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Card export breaks alphabetical ordering convention in index

Low Severity

The Card export is placed between Box and ButtonAnimated, breaking the file's alphabetical ordering convention. Since 'B' comes before 'C', all Button* exports precede Card alphabetically. The Card export belongs between ButtonIcon and Checkbox to maintain the established ordering used throughout this barrel file.

Fix in Cursor Fix in Web

georgewrmarshall added a commit that referenced this pull request Feb 20, 2026
## Summary

Reverts the failed Release 20.0.0 (#921) to redo it properly with
complete changelogs and correct yarn.lock.

## Context

Release 20.0.0 was merged to main but the publish workflow failed due to
a yarn.lock issue:
- **Failed workflow:**
https://github.com/MetaMask/metamask-design-system/actions/runs/22198282954
- **Root cause:** yarn.lock not updated when peer dependency changed

After the release was merged, 7 additional PRs were merged to main:
1. Label component (#907)
2. HeaderBase component (#902)
3. Skeleton (#891)
4. Card (#923)
5. BottomSheetFooter (#899)
6. Toast (#892)
7. Input component (#909)

## Why Revert?

To maintain clean version history and proper changelogs:
- Release 20.0.0 was never published to NPM (latest is 19.0.0)
- The 7 PRs merged after are not documented in Release 20.0.0 changelog
- Reverting allows us to create a proper Release 20.0.0 that includes
ALL changes

## Changes

This PR reverts commit `45004196` which:
- Restores package versions to pre-release state (8.1.1, 0.7.0, 0.6.0,
etc.)
- Restores root package.json version from 20.0.0 to 19.0.0
- Removes Release 20.0.0 changelog entries

## Next Steps

After this is merged:
1. Create new `release/20.0.0` branch using standard release process
2. Include all changes (original + 7 PRs) in changelogs
3. **Run `yarn install` to update yarn.lock**
4. Merge new Release 20.0.0 PR
5. Publish workflow will succeed with correct lockfile

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants