feat: label component#907
Merged
Merged
Conversation
brianacnguyen
approved these changes
Feb 17, 2026
brianacnguyen
requested changes
Feb 17, 2026
brianacnguyen
left a comment
Contributor
There was a problem hiding this comment.
can you attach a screen recording to the PR?
Collaborator
Author
|
@brianacnguyen done 🙌 |
georgewrmarshall
previously approved these changes
Feb 18, 2026
brianacnguyen
requested changes
Feb 19, 2026
brianacnguyen
left a comment
Contributor
There was a problem hiding this comment.
can you remove the default const?
brianacnguyen
previously approved these changes
Feb 19, 2026
8d4ef72 to
93935a3
Compare
georgewrmarshall
previously approved these changes
Feb 20, 2026
Contributor
There was a problem hiding this comment.
Can we remove this image in a follow up PR they tend to become out of date
|
|
||
| export const Default: Story = { | ||
| args: { | ||
| children: 'Sample Label Text', |
Contributor
There was a problem hiding this comment.
non-blocking: We should ensure that all of our content follows our content guidelines and is sentenced case
| const { getByTestId } = render( | ||
| <Label testID="label">Sample Label Text</Label>, | ||
| ); | ||
| expect(getByTestId('label')).toBeDefined(); |
Contributor
There was a problem hiding this comment.
non-blocking: Let's use toBeOnScreen moving forward to align with mobile unit test best practice
Comment on lines
+27
to
+41
| ### `variant` | ||
|
|
||
| Optional enum to select between typography variants. The Label defaults to `TextVariant.BodyMd`. | ||
|
|
||
| | TYPE | REQUIRED | DEFAULT | | ||
| | ------------- | -------- | -------------------- | | ||
| | `TextVariant` | No | `TextVariant.BodyMd` | | ||
|
|
||
| ```tsx | ||
| import { Label } from '@metamask/design-system-react-native'; | ||
| import { TextVariant } from '@metamask/design-system-react-native'; | ||
|
|
||
| <Label variant={TextVariant.BodySm}>Small Label</Label> | ||
| <Label>Default Label (BodyMd)</Label> | ||
| ``` |
Contributor
There was a problem hiding this comment.
non-blocking: we should think about if it makes sense to document this prop or would we prefer that the labels are keep consistent across the app in terms of font size/weight etc
93935a3 to
b5f64ee
Compare
georgewrmarshall
approved these changes
Feb 20, 2026
georgewrmarshall
added a commit
that referenced
this pull request
Feb 20, 2026
## Summary Reverts the failed Release 20.0.0 (#921) to redo it properly with complete changelogs and correct yarn.lock. ## Context Release 20.0.0 was merged to main but the publish workflow failed due to a yarn.lock issue: - **Failed workflow:** https://github.com/MetaMask/metamask-design-system/actions/runs/22198282954 - **Root cause:** yarn.lock not updated when peer dependency changed After the release was merged, 7 additional PRs were merged to main: 1. Label component (#907) 2. HeaderBase component (#902) 3. Skeleton (#891) 4. Card (#923) 5. BottomSheetFooter (#899) 6. Toast (#892) 7. Input component (#909) ## Why Revert? To maintain clean version history and proper changelogs: - Release 20.0.0 was never published to NPM (latest is 19.0.0) - The 7 PRs merged after are not documented in Release 20.0.0 changelog - Reverting allows us to create a proper Release 20.0.0 that includes ALL changes ## Changes This PR reverts commit `45004196` which: - Restores package versions to pre-release state (8.1.1, 0.7.0, 0.6.0, etc.) - Restores root package.json version from 20.0.0 to 19.0.0 - Removes Release 20.0.0 changelog entries ## Next Steps After this is merged: 1. Create new `release/20.0.0` branch using standard release process 2. Include all changes (original + 7 PRs) in changelogs 3. **Run `yarn install` to update yarn.lock** 4. Merge new Release 20.0.0 PR 5. Publish workflow will succeed with correct lockfile 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added
Labelcomponent aligning it with this repo guidelines.Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/DSYS-276
Manual testing steps
LabelexampleScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Additive UI component and exports with minimal logic; main risk is minor API surface/packaging or Storybook registration issues.
Overview
Adds a new
Labelcomponent that wrapsTextand defaults toTextVariant.BodyMd, withLabelPropsaliased toTextProps.Exposes
Labelfrom the design-system component barrel (components/index.ts), adds a Storybook story (and updates the auto-generatedstorybook.requires.js), includes basic render tests, and provides component documentation inLabel/README.md.Written by Cursor Bugbot for commit b5f64ee. This will update automatically on new commits. Configure here.