This repository was archived by the owner on Oct 16, 2025. It is now read-only.
Revert "fix: ensure middleware uses latest block number (#416)"#421
Merged
Revert "fix: ensure middleware uses latest block number (#416)"#421
Conversation
This reverts commit 65e0b97.
Gudahtt
reviewed
Oct 15, 2025
Gudahtt
previously approved these changes
Oct 15, 2025
Considering whether to merge this now or after reverting the breaking change on main
Gudahtt
pushed a commit
that referenced
this pull request
Oct 15, 2025
… core monorepo (#420)" (#423) This reverts commit 5391380. This breaking change is blocking a release fix that will include: 1. #421 2. #422 Will readd this commit after those two PRs are merged and a patch release is cut <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? Are there any issues or other links reviewers should consult to understand this pull request better? For instance: * Fixes #12345 * See: #67890 -->
Mrtenz
pushed a commit
to MetaMask/core
that referenced
this pull request
Oct 16, 2025
… core monorepo (#420)" (#423) This reverts commit d10c455. This breaking change is blocking a release fix that will include: 1. MetaMask/eth-json-rpc-middleware#421 2. MetaMask/eth-json-rpc-middleware#422 Will readd this commit after those two PRs are merged and a patch release is cut <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? Are there any issues or other links reviewers should consult to understand this pull request better? For instance: * Fixes #12345 * See: #67890 -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 65e0b97.
Note
Remove
useCache: falsefromPollingBlockTracker.getLatestBlock()calls across middlewares; update changelog and raise Jest coverage thresholds.useCache: falsefromPollingBlockTracker.getLatestBlock()insrc/block-cache.ts,src/block-ref-rewrite.ts,src/block-ref.ts, andsrc/retryOnEmpty.ts.#416.branches,functions,lines,statements).Written by Cursor Bugbot for commit 2edc83d. This will update automatically on new commits. Configure here.