This repository was archived by the owner on Oct 16, 2025. It is now read-only.
refactor!: Synchronize dev toolchain with module template and core monorepo#420
Merged
refactor!: Synchronize dev toolchain with module template and core monorepo#420
Conversation
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
6b465ea to
2c6c21e
Compare
Member
Author
|
@SocketSecurity ignore-all These are all direct or transitive dependencies of dev deps that we use in the module template. They either have powerful capabilities that they need, or have "new" authors that all appear to be known quantities. |
Mrtenz
previously approved these changes
Oct 13, 2025
Mrtenz
previously approved these changes
Oct 13, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jiexi
reviewed
Oct 13, 2025
test/util/helpers.ts
Outdated
| res.result = 'default result'; | ||
| } | ||
| res.jsonrpc ??= '2.0'; | ||
| res.result ??= 'default result'; |
Member
There was a problem hiding this comment.
This would replace null now. Is that okay?
Member
Author
There was a problem hiding this comment.
Yes, but only because it's a test utility and the tests still pass. On review, it's still seems inappropriate for this function, so I reverted it.
jiexi
previously approved these changes
Oct 13, 2025
matthewwalsh0
approved these changes
Oct 13, 2025
jiexi
approved these changes
Oct 13, 2025
Mrtenz
approved these changes
Oct 13, 2025
Gudahtt
pushed a commit
that referenced
this pull request
Oct 15, 2025
… core monorepo (#420)" (#423) This reverts commit 5391380. This breaking change is blocking a release fix that will include: 1. #421 2. #422 Will readd this commit after those two PRs are merged and a patch release is cut <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? Are there any issues or other links reviewers should consult to understand this pull request better? For instance: * Fixes #12345 * See: #67890 -->
Gudahtt
pushed a commit
that referenced
this pull request
Oct 15, 2025
…d core monorepo (#420)" (#423) (#426) This reverts commit c591a5f (Reapplies 5391380) <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? Are there any issues or other links reviewers should consult to understand this pull request better? For instance: * Fixes #12345 * See: #67890 --> <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Overhauls the dev toolchain: upgrades ESLint to v9 with new configs/plugins, moves to TypeScript 5.x, adds TypeDoc/depcheck/ts-bridge/ATTW tooling, updates Prettier to v3, and refreshes dependencies. > > - **Dev toolchain sync/upgrade** > - **ESLint 9**: Bump core and configs (MetaMask v14), migrate plugins/resolvers (e.g., `eslint-plugin-import-x`, `eslint-import-resolver-typescript`), and update related utilities. > - **TypeScript 5.x**: Update TypeScript, `typescript-eslint` (v8), `ts-node`, and supporting packages. > - **Formatting & docs**: Upgrade **Prettier** to v3 and `prettier-plugin-packagejson`; add **TypeDoc**. > - **New tooling**: Add `@arethetypeswrong/cli`, `@ts-bridge/cli`, and **depcheck** for dependency hygiene. > - **Dependencies**: Broad dependency updates and lockfile refresh to align with core template. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 5ef56a4. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronizes package meta-files with https://github.com/MetaMask/metamask-module-template. Changes exclude source code and other published files with the following exceptions:
package.json, most notably itsexportsfieldts-bridgefor builds.ts-bridgeis arguably breaking, although it should only improve the experience of our consumers..cjsand.mjstrees perts-bridgeIn detail (all changes per module template unless otherwise specified):
ts-bridgeeslint,prettier, and related dependencieseslint.config.mjs@arethetypeswrong/clitypedoc.yarnrc.ymland addyarn.config.cjspackage.jsonandREADME.mdtypescriptfrom4.xto~5.7.3jestand related dependencies from^27to^28tsconfigfilestest/setupAfterEnv.tswarn:@typescript-eslint/prefer-nullish-coalescing, to avoid behavioral changes@typescript-eslint/explicit-function-return-type, because too many violations to fix right nowWork intentionally avoided in this PR:
package.json#enginesvitestNote
Migrates build to ts-bridge and aligns tooling with the MetaMask module template (ESLint v9 flat config, TypeScript 5.x, TypeDoc, Yarn constraints), with no runtime code changes.
yarn.config.cjs, update.yarnrc.yml, and standardizepackage.jsonfields/exports.~5.xand adopttypescript-eslint@^8.eslint.config.mjsand MetaMask configs v14.ts-bridge; publish splitdistoutputs (.cjs/.mjs).@arethetypeswrong/cliand related tooling checks.typedoc.jsonandtypedocfor API docs generation.yarn.lockand ancillary dev deps (e.g., jest ecosystem kept at 27.x).test/setupAfterEnv.ts(per PR notes).Written by Cursor Bugbot for commit 7b8b457. This will update automatically on new commits. Configure here.