Merged
Conversation
3 tasks
Contributor
|
Published as |
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 21 21
Lines 1254 1273 +19
Branches 156 158 +2
=====================================
+ Hits 1254 1273 +19
Continue to review full report at Codecov.
|
bitpshr
approved these changes
Apr 1, 2019
mcmire
pushed a commit
to mcmire/core
that referenced
this pull request
Jul 17, 2023
…Mask#52)" (MetaMask#82) This reverts commit d2a09d6.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* fix requesting code for txs without tx to * rm files * handle method data wothout saving in state * add test * fix race condition * fix includeS * tests * add missing doc * use npm eth-method-registry
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* fix requesting code for txs without tx to * rm files * handle method data wothout saving in state * add test * fix race condition * fix includeS * tests * add missing doc * use npm eth-method-registry
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
* Update eslint and TypeScript configs, lint * Update CI config * Add test:nobuild command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
eth-method-registryto maintain transaction four byte method signatures, usinghandleMethodData, a method that can be used from mobile or the extension without interfering howTransactionControllercurrently works.This method receives a new four byte method signature. If that signature isn't known, is going to save it in state and return it. Next time is needed query the contract won't be necessary, having only one request per signature sent to the on-chain contract.