Only update TransactionController state if got updates#52
Merged
brunobar79 merged 3 commits intomasterfrom Jan 4, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 20 20
Lines 1011 1014 +3
Branches 112 113 +1
=====================================
+ Hits 1011 1014 +3
Continue to review full report at Codecov.
|
3 tasks
bitpshr
approved these changes
Jan 4, 2019
mcmire
pushed a commit
to mcmire/core
that referenced
this pull request
Jul 17, 2023
* Handle 'toJSON' in JSON validation and sizing * Return parsed JSON value from validation function * Rename return type * Fix lint errors * Add helper functions * Slightly simplify code
mcmire
pushed a commit
to mcmire/core
that referenced
this pull request
Jul 17, 2023
…Mask#52)" (MetaMask#82) This reverts commit d2a09d6.
kanthesha
pushed a commit
that referenced
this pull request
Sep 19, 2023
kanthesha
pushed a commit
that referenced
this pull request
Oct 11, 2023
* 100% test coverage everywhere * add nyc config, check coverage, use in CI * add next handler test case * add async handle tests * add sinon; use stub
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* only update state if got updates * fix codecov * tests
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* only update state if got updates * fix codecov * tests
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 12, 2023
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
This change deletes the unused CircleCI config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because queryTransactionStatuses is running inside a setInterval we're telling GABA that the state was updated even when there are no changes.
This PR adds a flag to make sure the state gets updated only when at least 1 TX status changed.