Merged
Conversation
cryptodev-2s
previously requested changes
Jun 6, 2025
Contributor
Author
|
@cryptodev-2s I don't understand why these other packages are receiving this version change that I don't expect. I would expect other packages to continue with the version they were using before. Will discuss with you in slack |
ccd64c3 to
864c224
Compare
cryptodev-2s
reviewed
Jun 6, 2025
15a636f to
1419a91
Compare
Matt561
previously approved these changes
Jun 6, 2025
1419a91 to
6f32a75
Compare
mcmire
reviewed
Jun 6, 2025
Contributor
mcmire
left a comment
There was a problem hiding this comment.
One small thing but otherwise good to go!
e6c5370 to
aaefe12
Compare
All requested changes seem to be addressed.
mcmire
reviewed
Jun 6, 2025
Comment on lines
10
to
14
| ### Changed | ||
|
|
||
| - Bump `@metamask/controller-utils` to `^11.10.0` ([#5935](https://github.com/MetaMask/core/pull/5935)) | ||
|
|
||
| ### Changed | ||
|
|
||
| - Bump `@metamask/base-controller` from ^8.0.0 to ^8.0.1 ([#5722](https://github.com/MetaMask/core/pull/5722)) | ||
| - Bump `@metamask/controller-utils` to `^11.9.0` ([#5583](https://github.com/MetaMask/core/pull/5583), [#5765](https://github.com/MetaMask/core/pull/5765), [#5812](https://github.com/MetaMask/core/pull/5812)) |
Contributor
There was a problem hiding this comment.
It looks like you can merge these:
Suggested change
| ### Changed | |
| - Bump `@metamask/controller-utils` to `^11.10.0` ([#5935](https://github.com/MetaMask/core/pull/5935)) | |
| ### Changed | |
| - Bump `@metamask/base-controller` from ^8.0.0 to ^8.0.1 ([#5722](https://github.com/MetaMask/core/pull/5722)) | |
| - Bump `@metamask/controller-utils` to `^11.9.0` ([#5583](https://github.com/MetaMask/core/pull/5583), [#5765](https://github.com/MetaMask/core/pull/5765), [#5812](https://github.com/MetaMask/core/pull/5812)) | |
| ### Changed | |
| - Bump `@metamask/base-controller` from ^8.0.0 to ^8.0.1 ([#5722](https://github.com/MetaMask/core/pull/5722)) | |
| - Bump `@metamask/controller-utils` to `^11.10.0` ([#5583](https://github.com/MetaMask/core/pull/5583), [#5765](https://github.com/MetaMask/core/pull/5765), [#5812](https://github.com/MetaMask/core/pull/5812), [#5935](https://github.com/MetaMask/core/pull/5935)) |
Contributor
Author
There was a problem hiding this comment.
Ok let me see if the lint passes as yarn changelog:validate is not catching the same errors ci seems to be. I'll make this change shortly
aaefe12 to
e795de5
Compare
cryptodev-2s
reviewed
Jun 6, 2025
Comment on lines
13
to
14
| - Bump `@metamask/network-controller` to `^23.6.0` ([#5935](https://github.com/MetaMask/core/pull/5935)) | ||
| - Bump `@metamask/network-controller` to `^23.5.1` ([#5882](https://github.com/MetaMask/core/pull/5882)) |
Contributor
There was a problem hiding this comment.
Can we merge these two ?
cryptodev-2s
reviewed
Jun 6, 2025
|
|
||
| - Bump `@metamask/controller-utils` to `^11.10.0` ([#5935](https://github.com/MetaMask/core/pull/5935)) | ||
| - Bump `@metamask/chain-agnostic-permission` to `^0.7.0` ([#5518](https://github.com/MetaMask/core/pull/5518), [#5674](https://github.com/MetaMask/core/pull/5674), [#5818](https://github.com/MetaMask/core/pull/5818)[#5583](https://github.com/MetaMask/core/pull/5583)) | ||
| - Bump `@metamask/controller-utils` to `^11.9.0` ([#5583](https://github.com/MetaMask/core/pull/5583), [#5765](https://github.com/MetaMask/core/pull/5765), [#5812](https://github.com/MetaMask/core/pull/5812)) |
Contributor
There was a problem hiding this comment.
Can we merge both controller utils under this Changed Section
packages/ens-controller/CHANGELOG.md
Outdated
|
|
||
| ### Changed | ||
|
|
||
| - Bump `@metamask/controller-utils` to `^11.10.0` ([#5935](https://github.com/MetaMask/core/pull/5935)) |
Contributor
There was a problem hiding this comment.
Can we merge both controller utils under the Changed Section
|
|
||
| ### Changed | ||
|
|
||
| - Bump `@metamask/controller-utils` to `^11.10.0` ([#5935](https://github.com/MetaMask/core/pull/5935)) |
Contributor
There was a problem hiding this comment.
Could we merge this with the below controller-utils bump while keeping one Changed Section
|
|
||
| ### Changed | ||
|
|
||
| - Bump `@metamask/controller-utils` to `^11.10.0` ([#5935](https://github.com/MetaMask/core/pull/5935)) |
Contributor
There was a problem hiding this comment.
Could we merge both controller-utils bumps in this section?
|
|
||
| ### Changed | ||
|
|
||
| - Bump `@metamask/controller-utils` to `^11.10.0` ([#5935](https://github.com/MetaMask/core/pull/5935)) |
Contributor
There was a problem hiding this comment.
Could we merge both controller-utils bumps while keeping one Changed section
|
|
||
| ### Changed | ||
|
|
||
| - Bump `@metamask/controller-utils` to `^11.10.0` ([#5935](https://github.com/MetaMask/core/pull/5935)) |
Contributor
There was a problem hiding this comment.
Could we merge both controller-utils bumps while keeping one Changed Section
|
|
||
| ### Changed | ||
|
|
||
| - Bump `@metamask/controller-utils` to `^11.10.0` ([#5935](https://github.com/MetaMask/core/pull/5935)) |
Contributor
There was a problem hiding this comment.
Could we merge both controller-utils bumps while keeping one Changed Section
|
|
||
| ### Changed | ||
|
|
||
| - Bump `@metamask/controller-utils` to `^11.10.0` ([#5935](https://github.com/MetaMask/core/pull/5935)) |
Contributor
There was a problem hiding this comment.
Could we merge both controller-utils bumps while keeping one Changed Section
|
|
||
| ### Changed | ||
|
|
||
| - Bump `@metamask/controller-utils` to `^11.10.0` ([#5935](https://github.com/MetaMask/core/pull/5935)) |
Contributor
There was a problem hiding this comment.
Could we merge both controller-utils bumps while keeping one Changed Section
|
|
||
| ### Changed | ||
|
|
||
| - Bump `@metamask/controller-utils` to `^11.10.0` ([#5935](https://github.com/MetaMask/core/pull/5935)) |
Contributor
There was a problem hiding this comment.
Could we merge both controller-utils bumps while keeping one Changed Section
e795de5 to
165b20b
Compare
Contributor
Author
|
Thank you two for the review, I just realized I was misusing the validation script and so I thought it was passing for me locally, but alas, it was not. I understand what I was doing wrong now! |
Contributor
Author
|
@mcmire @cryptodev-2s I think it should be gtg this time 🤞🏽 |
Merged
adonesky1
added a commit
that referenced
this pull request
Jun 13, 2025
## @metamask/chain-agnostic-permission ## [0.7.1] ### Changed - Bump `@metamask/keyring-internal-api` to `^6.2.0` ([#5871](#5871)) - Bump `@metamask/controller-utils` to `^11.10.0` ([#5935](#5935)) - Bump `@metamask/network-controller` to `^23.6.0` ([#5935](https://github.com/MetaMask/core/pull/5935),[#5882](https://github.com/MetaMask/core/pull/5882)) - Change `caip25CaveatBuilder` to list unsupported scopes in the unsupported scopes error ([#5806](#5806)) ### Fixed - Fix `isInternalAccountInPermittedAccountIds` and `isCaipAccountIdInPermittedAccountIds` to correctly handle comparison against `permittedAccounts` values of the `wallet:<namespace>:<address>` format ([#5980](#5980))
Merged
adonesky1
added a commit
that referenced
this pull request
Jun 20, 2025
## @metamask/chain-agnostic-permission ## [1.0.0] ### Changed - This package is now considered stable ## @metamask/eip1193-permission-middleware ## [1.0.0] ### Changed - Bump `@metamask/chain-agnostic-permission` to `^0.8.0` ([#5518](#5518), [#5674](#5674), [#5818](https://github.com/MetaMask/core/pull/5818)[#5583](https://github.com/MetaMask/core/pull/5583), [#5982](https://github.com/MetaMask/core/pull/5982),[#6004](https://github.com/MetaMask/core/pull/6004)) - Bump `@metamask/chain-agnostic-permission` to `^0.8.0` ([#5550](#5550), [#5518](#5518), [#5674](#5674), [#5715](#5715), [#5760](#5760), [#5818](https://github.com/MetaMask/core/pull/5818)[#5583](https://github.com/MetaMask/core/pull/5583), [#5982](https://github.com/MetaMask/core/pull/5982),[#6004](https://github.com/MetaMask/core/pull/6004)) - Bump `@metamask/controller-utils` to `^11.10.0` ([#5935](#5935), [#5583](#5583), [#5765](#5765), [#5812](#5812)) ## @metamask/multichain-api-middleware ## [1.0.0] ### Changed - Bump `@metamask/chain-agnostic-permission` to `^0.8.0` ([#5518](#5518), [#5674](#5674), [#5818](https://github.com/MetaMask/core/pull/5818)[#5583](https://github.com/MetaMask/core/pull/5583), [#5982](https://github.com/MetaMask/core/pull/5982),[#6004](https://github.com/MetaMask/core/pull/6004)) - Bump `@metamask/chain-agnostic-permission` to `^0.8.0` ([#5550](#5550), [#5518](#5518), [#5674](#5674), [#5715](#5715), [#5760](#5760), [#5818](https://github.com/MetaMask/core/pull/5818)[#5583](https://github.com/MetaMask/core/pull/5583), [#5982](https://github.com/MetaMask/core/pull/5982),[#6004](https://github.com/MetaMask/core/pull/6004)) - Bump `@metamask/controller-utils` to `^11.10.0` ([#5935](#5935), [#5583](#5583), [#5765](#5765), [#5812](#5812))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Release core v 430.0.0
Checklist