Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
ce31ef4 to
29e04f1
Compare
29e04f1 to
e49ec95
Compare
Contributor
Author
|
Adding the |
ccharly
commented
May 30, 2025
| ); | ||
| const getAccounts = jest.fn().mockReturnValue([]); | ||
| const response: PendingJsonRpcResponse<Json> = { | ||
| const response: PendingJsonRpcResponse = { |
Contributor
Author
There was a problem hiding this comment.
Most of those changes are required because of @metamask/utils dedupe. The default type parameter for those is Json already, resulting in a eslint warning if we specify it.
See:
ffmcgee725
approved these changes
May 30, 2025
Member
ffmcgee725
left a comment
There was a problem hiding this comment.
CO review for wallet-api-platform-engineers team, only typing changes which make sense. LGTM 👍🏾 🚀
Merged
adonesky1
added a commit
that referenced
this pull request
Jun 13, 2025
## @metamask/chain-agnostic-permission ## [0.7.1] ### Changed - Bump `@metamask/keyring-internal-api` to `^6.2.0` ([#5871](#5871)) - Bump `@metamask/controller-utils` to `^11.10.0` ([#5935](#5935)) - Bump `@metamask/network-controller` to `^23.6.0` ([#5935](https://github.com/MetaMask/core/pull/5935),[#5882](https://github.com/MetaMask/core/pull/5882)) - Change `caip25CaveatBuilder` to list unsupported scopes in the unsupported scopes error ([#5806](#5806)) ### Fixed - Fix `isInternalAccountInPermittedAccountIds` and `isCaipAccountIdInPermittedAccountIds` to correctly handle comparison against `permittedAccounts` values of the `wallet:<namespace>:<address>` format ([#5980](#5980))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Updating
accountsdeps + aligningsnapsdeps as well.The main update here is
@metamask/eth-snap-keyringwhich introduce the newKeyringRequest.originfield. This new breaking change is associated with the Snaps platform version: 7.0.0 (@metamask/snaps-sdk@7.0.0).References
N/A
Changelog
N/A
Checklist