Feat/add app metadata controller#5325
Merged
Merged
Conversation
mikesposito
reviewed
Feb 20, 2025
Member
There was a problem hiding this comment.
I see that this controller has no public method, how do we intend the client to interact with this package?
I just realized that the extension is already using the package via the constructor alone, which I feel is a little weird, but I guess goes beyond the scope of this PR
Member
|
Could we add a root // src/index.ts
export * from './AppMetadataController` |
Member
|
We should also add these changes to configuration files:
Also, |
…k/core into feat/add-app-metadata-controller
7 tasks
mcmire
reviewed
Mar 18, 2025
…k/core into feat/add-app-metadata-controller
mcmire
reviewed
Mar 21, 2025
mcmire
reviewed
Mar 31, 2025
mcmire
left a comment
Contributor
There was a problem hiding this comment.
It looks like lint is failing. I provided some suggestions on how to fix it.
If you need to run lint for just these files again, try
yarn eslint packages/app-metadata-controller
mcmire
reviewed
Mar 31, 2025
…k/core into feat/add-app-metadata-controller
mcmire
reviewed
Mar 31, 2025
mcmire
left a comment
Contributor
There was a problem hiding this comment.
One more thing and then I think we're good.
7 tasks
github-merge-queue Bot
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Apr 12, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** * Integrates new AppMetadataController in mobile * [New Controller PR](MetaMask/core#5325) <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  #### State Logs [state-logs-v7.43.0-(1656).json](https://github.com/user-attachments/files/19708029/state-logs-v7.43.0-.1656.json) <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Cal-L <cleun007@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Porting over the AppMetadataController from Extension
References
Changelog
@metamask/app-metadata-controllerChecklist