Skip to content

Integrate App Metadata Controller#14513

Merged
frankvonhoven merged 34 commits into
mainfrom
add/app-metadata-controller
Apr 12, 2025
Merged

Integrate App Metadata Controller#14513
frankvonhoven merged 34 commits into
mainfrom
add/app-metadata-controller

Conversation

@frankvonhoven

@frankvonhoven frankvonhoven commented Apr 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Screenshot 2025-04-11 at 9 39 58 AM

State Logs

state-logs-v7.43.0-(1656).json

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@frankvonhoven frankvonhoven requested a review from a team April 8, 2025 15:51
@frankvonhoven frankvonhoven requested a review from a team as a code owner April 8, 2025 15:51
@github-actions

github-actions Bot commented Apr 8, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@frankvonhoven frankvonhoven added team-mobile-platform Mobile Platform team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Apr 8, 2025
@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue Apr 8, 2025
@github-actions

github-actions Bot commented Apr 8, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3f0651c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a1206849-4920-4335-a9aa-aa9d383d5023

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@socket-security

socket-security Bot commented Apr 9, 2025 •
edited
Loading

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub ↗.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Added@​metamask/​app-metadata-controller@​1.0.0711006989100

View full report ↗

Cal-L
Cal-L previously approved these changes Apr 11, 2025
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Apr 11, 2025
@frankvonhoven frankvonhoven requested a review from a team as a code owner April 11, 2025 22:09
@frankvonhoven frankvonhoven enabled auto-merge April 11, 2025 22:14
Cal-L
Cal-L previously approved these changes Apr 11, 2025
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter

codecov-commenter commented Apr 11, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.28%. Comparing base (08382bc) to head (c30c3cd).
Report is 43 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14513      +/-   ##
==========================================
+ Coverage   66.57%   67.28%   +0.70%     
==========================================
  Files        2257     2279      +22     
  Lines       48273    48890     +617     
  Branches     6823     6980     +157     
==========================================
+ Hits        32139    32896     +757     
+ Misses      14102    13924     -178     
- Partials     2032     2070      +38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Cal-L
Cal-L approved these changes Apr 12, 2025
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud

sonarqubecloud Bot commented Apr 12, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Cal-L Cal-L added the No QA Needed Apply this label when your PR does not need any QA effort. label Apr 12, 2025
@frankvonhoven frankvonhoven added this pull request to the merge queue Apr 12, 2025
Merged via the queue into main with commit 60db831 Apr 12, 2025
@frankvonhoven frankvonhoven deleted the add/app-metadata-controller branch April 12, 2025 00:40
@github-project-automation github-project-automation Bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Apr 12, 2025
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 12, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 12, 2025
@metamaskbot metamaskbot added the release-7.46.0 Issue or pull request that will be included in release 7.46.0 label Apr 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Cal-L Cal-L Cal-L approved these changes

@tommasini tommasini tommasini approved these changes

Assignees

No one assigned

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.46.0 Issue or pull request that will be included in release 7.46.0 team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@frankvonhoven @codecov-commenter @Cal-L @tommasini @gauthierpetetin @metamaskbot