Only apply TypeScript lint rules to .ts files#396
Merged
Conversation
8e1bf7f to
19b094b
Compare
brad-decker
previously approved these changes
Mar 16, 2021
The TypeScript lint rules were being applied to all files covered by the linter, including JavaScript files. Surprisingly this hasn't been much of an issue (I guess most of them are compatible with JavaScript too?), but it became an obstacle when trying to re-enable the rule `@typescript-eslint/no-shadow`. TypeScript lint rules are now only applied to TypeScript files. A new dependency was required to ensure we could import TypeScript modules from JavaScript modules. We do this in one place at the moment, in the JavaScript tests for the ApprovalController. Apparently the ESLint `import` plugin doesn't know how to resolve TypeScript modules without a custom resolver. We hadn't encountered this problem previously because `import/no-unresolved` was disabled in our TypeScript ESLint config, so it didn't warn us about the dependency being unresolved. The `ecmaVersion` was also updated to be 2018 for JavaScript files, to reflect the language features we currently rely upon (we use object spread in one place, which was introduced in ES2018).
19b094b to
3ee0490
Compare
Member
Author
|
This has been rebased to resolve conflcits |
brad-decker
approved these changes
Mar 16, 2021
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The TypeScript lint rules were being applied to all files covered by the linter, including JavaScript files. Surprisingly this hasn't been much of an issue (I guess most of them are compatible with JavaScript too?), but it became an obstacle when trying to re-enable the rule `@typescript-eslint/no-shadow`. TypeScript lint rules are now only applied to TypeScript files. A new dependency was required to ensure we could import TypeScript modules from JavaScript modules. We do this in one place at the moment, in the JavaScript tests for the ApprovalController. Apparently the ESLint `import` plugin doesn't know how to resolve TypeScript modules without a custom resolver. We hadn't encountered this problem previously because `import/no-unresolved` was disabled in our TypeScript ESLint config, so it didn't warn us about the dependency being unresolved. The `ecmaVersion` was also updated to be 2018 for JavaScript files, to reflect the language features we currently rely upon (we use object spread in one place, which was introduced in ES2018).
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The TypeScript lint rules were being applied to all files covered by the linter, including JavaScript files. Surprisingly this hasn't been much of an issue (I guess most of them are compatible with JavaScript too?), but it became an obstacle when trying to re-enable the rule `@typescript-eslint/no-shadow`. TypeScript lint rules are now only applied to TypeScript files. A new dependency was required to ensure we could import TypeScript modules from JavaScript modules. We do this in one place at the moment, in the JavaScript tests for the ApprovalController. Apparently the ESLint `import` plugin doesn't know how to resolve TypeScript modules without a custom resolver. We hadn't encountered this problem previously because `import/no-unresolved` was disabled in our TypeScript ESLint config, so it didn't warn us about the dependency being unresolved. The `ecmaVersion` was also updated to be 2018 for JavaScript files, to reflect the language features we currently rely upon (we use object spread in one place, which was introduced in ES2018).
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
Adds methods `wallet_requestExecutionPermissions` and `wallet_revokeExecutionPermission`, as defined in this revision of the EIP-7715 specification ethereum/ERCs#1098. This supports Readable Permissions project, and is related to the following PRs: - MetaMask/smart-accounts-kit#60 - MetaMask/metamask-extension#35193 Note: workflows are failing due to existing problems, fixed by MetaMask/eth-json-rpc-middleware#397
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
This is the release for version 17.1.0. ``` 4e74bb9 feat: add RPC methods described in (revised) EIP-7715 (#396) 0a66477 Run compatibility test only in main branch. (#397) ``` --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Jeff Smale <6363749+jeffsmale90@users.noreply.github.com> Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TypeScript lint rules were being applied to all files covered by the linter, including JavaScript files. Surprisingly this hasn't been much of an issue (I guess most of them are compatible with JavaScript too?), but it became an obstacle when trying to re-enable the rule
@typescript-eslint/no-shadow.TypeScript lint rules are now only applied to TypeScript files.
A new dependency was required to ensure we could import TypeScript modules from JavaScript modules. We do this in one place at the moment, in the JavaScript tests for the ApprovalController. Apparently the ESLint
importplugin doesn't know how to resolve TypeScript modules without a custom resolver. We hadn't encountered this problem previously becauseimport/no-unresolvedwas disabled in our TypeScript ESLint config, so it didn't warn us about the dependency being unresolved.The
ecmaVersionwas also updated to be 2018 for JavaScript files, to reflect the language features we currently rely upon (we use object spread in one place, which was introduced in ES2018).