Skip to content

Poll GitHub for phishing config file#232

Merged
whymarrh merged 2 commits intoMetaMask:developfrom
whymarrh:blacklist-endpoint-dev
May 7, 2020
Merged

Poll GitHub for phishing config file#232
whymarrh merged 2 commits intoMetaMask:developfrom
whymarrh:blacklist-endpoint-dev

Conversation

@whymarrh
Copy link
Copy Markdown
Contributor

@whymarrh whymarrh commented May 7, 2020

Closes #219

Like #229, but for develop/2.x:

This PR removes the usage of the https://api.infura.io/v2/blacklist endpoint, replacing it with fetching the config from GitHub directly.

@whymarrh whymarrh requested a review from a team May 7, 2020 19:37
Gudahtt
Gudahtt approved these changes May 7, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whymarrh whymarrh merged commit 188279a into MetaMask:develop May 7, 2020
@whymarrh whymarrh deleted the blacklist-endpoint-dev branch May 7, 2020 20:02
@whymarrh whymarrh mentioned this pull request Sep 15, 2020
Merged
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@whymarrh @MajorLift
Poll GitHub for phishing config file (#232)
d4d5d68
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@whymarrh @MajorLift
Poll GitHub for phishing config file (#232)
8225e46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace Infura blacklist endpoint

2 participants

@whymarrh @Gudahtt