Skip to content

Poll GitHub for phishing config file#229

Merged
whymarrh merged 1 commit intoMetaMask:1.xfrom
whymarrh:blacklist-endpoint
May 7, 2020
Merged

Poll GitHub for phishing config file#229
whymarrh merged 1 commit intoMetaMask:1.xfrom
whymarrh:blacklist-endpoint

Conversation

@whymarrh
Copy link
Copy Markdown
Contributor

@whymarrh whymarrh commented May 7, 2020

Refs #219

This PR removes the usage of the https://api.infura.io/v2/blacklist endpoint, replacing it with fetching the config from GitHub directly.

@whymarrh whymarrh force-pushed the blacklist-endpoint branch from 2460b2a to bf20eba Compare May 7, 2020 18:37
@whymarrh whymarrh force-pushed the blacklist-endpoint branch from bf20eba to 4bb3bbd Compare May 7, 2020 18:45
@whymarrh whymarrh marked this pull request as ready for review May 7, 2020 18:48
@whymarrh whymarrh requested a review from a team May 7, 2020 18:48
@whymarrh
Copy link
Copy Markdown
Contributor Author

whymarrh commented May 7, 2020

This is the 1.x branch, ignore the CircleCI error as this branch is pre-CircleCI config.

@whymarrh
Copy link
Copy Markdown
Contributor Author

whymarrh commented May 7, 2020

I'm going to create a similar fix for develop and cut a 2.x release.

@whymarrh
Copy link
Copy Markdown
Contributor Author

whymarrh commented May 7, 2020

I've tested this change with the extension and it works as expected

Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whymarrh whymarrh merged commit 55408d5 into MetaMask:1.x May 7, 2020
@whymarrh whymarrh deleted the blacklist-endpoint branch May 7, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants