Skip to content

devDeps: update eslint packages#1498

Merged
Gudahtt merged 19 commits intoMetaMask:mainfrom
legobeat:devdeps-eslint-rebased-202307
Jul 14, 2023
Merged

devDeps: update eslint packages#1498
Gudahtt merged 19 commits intoMetaMask:mainfrom
legobeat:devdeps-eslint-rebased-202307

Conversation

@legobeat
Copy link
Copy Markdown
Contributor

@legobeat legobeat commented Jul 13, 2023 •
edited
Loading

Explanation

Another rehash of #1014 and #1277, with more conservative enabling of rules introduced through @metamask/eslint-config* package updates.

References

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@legobeat legobeat force-pushed the devdeps-eslint-rebased-202307 branch from 7a1fe0f to 75df23a Compare July 13, 2023 23:13
legobeat
legobeat commented Jul 13, 2023
View reviewed changes
@legobeat legobeat marked this pull request as ready for review July 13, 2023 23:25
@legobeat legobeat requested review from a team as code owners July 13, 2023 23:25
This was referenced Jul 13, 2023
Closed
Closed
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Jul 14, 2023
@socket-security
Copy link
Copy Markdown

socket-security bot commented Jul 14, 2023

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
eslint-plugin-promise 6.1.1 None +23 6.17 MB eslint-community-bot
eslint-plugin-n 15.7.0 filesystem +26 6.67 MB weiran.zsd
@metamask/eslint-config-jest 9.0.0...12.1.0 None +38/-38 10.9 MB metamaskbot
@metamask/eslint-config-typescript 9.0.1...12.1.0 None +37/-37 50.2 MB metamaskbot
@metamask/eslint-config-nodejs 9.0.0...12.1.0 None +34/-29 9.3 MB metamaskbot
@metamask/eslint-config 9.0.0...12.1.0 None +30/-26 8.71 MB metamaskbot
@typescript-eslint/parser 4.33.0...5.62.0 None +28/-26 7.58 MB jameshenry
eslint 7.32.0...8.44.0 environment +22/-18 6.11 MB eslintbot
eslint-plugin-jsdoc 36.1.1...39.9.1 None +27/-24 8.46 MB gajus
eslint-plugin-prettier 3.4.1...4.2.1 None +23/-19 6.17 MB jounqin
eslint-plugin-jest 24.7.0...27.2.3 None +30/-29 8.4 MB simenb

🚮 Removed packages: @typescript-eslint/eslint-plugin@4.33.0, eslint-plugin-node@11.1.0

@socket-security
Copy link
Copy Markdown

socket-security bot commented Jul 14, 2023 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @eslint/js@8.44.0, @typescript-eslint/utils@5.62.0, argparse@2.0.1, builtins@5.0.1, yocto-queue@0.1.0, is-path-inside@3.0.3, @eslint/eslintrc@2.1.0, eslint-plugin-n@15.7.0

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat
Copy link
Copy Markdown
Contributor Author

legobeat commented Jul 14, 2023 

@SocketSecurity ignore @eslint/js@8.44.0
@SocketSecurity ignore @typescript-eslint/utils@5.62.0
@SocketSecurity ignore argparse@2.0.1
@SocketSecurity ignore builtins@5.0.1
@SocketSecurity ignore yocto-queue@0.1.0
@SocketSecurity ignore is-path-inside@3.0.3
@SocketSecurity ignore @eslint/eslintrc@2.1.0
@SocketSecurity ignore eslint-plugin-n@15.7.0

Gudahtt
Gudahtt reviewed Jul 14, 2023
View reviewed changes
Gudahtt
Gudahtt reviewed Jul 14, 2023
View reviewed changes
Gudahtt
Gudahtt reviewed Jul 14, 2023
View reviewed changes
Gudahtt
Gudahtt reviewed Jul 14, 2023
View reviewed changes
@Gudahtt
Copy link
Copy Markdown
Member

Gudahtt commented Jul 14, 2023

New peer dependency warning:

@metamask/core-monorepo@workspace:. provides typescript (pcb988) with version 4.6.3, which doesn't satisfy what @metamask/eslint-config-typescript requests

Though main is already in an incompatible state (it has a different TypeScript incompatibility, see the warning when yarn lint is run on main), so this still seems like a step forward. We should make updating TypeScript a priority though.

@legobeat legobeat force-pushed the devdeps-eslint-rebased-202307 branch from 8cb1d00 to a0d0e6a Compare July 14, 2023 04:17
@legobeat legobeat requested review from a team and Gudahtt July 14, 2023 04:23
Gudahtt
Gudahtt reviewed Jul 14, 2023
View reviewed changes
Gudahtt
Gudahtt reviewed Jul 14, 2023
View reviewed changes
Gudahtt
Gudahtt previously approved these changes Jul 14, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat
Copy link
Copy Markdown
Contributor Author

legobeat commented Jul 14, 2023

@MetaMask/snaps-devs approval needed for merge

@legobeat legobeat force-pushed the devdeps-eslint-rebased-202307 branch from 89ae441 to c6ee352 Compare July 14, 2023 05:19
FrederikBolding
FrederikBolding approved these changes Jul 14, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@FrederikBolding FrederikBolding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Note: I have only reviewed the files under snaps ownership since the PR already has two other approvals

@Gudahtt Gudahtt merged commit ea879d2 into MetaMask:main Jul 14, 2023
@legobeat legobeat deleted the devdeps-eslint-rebased-202307 branch July 14, 2023 21:59
This was referenced Jul 14, 2023
Closed
Closed
Closed
Closed
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@legobeat @Gudahtt @MajorLift
devDeps: update eslint packages (#1498)
9ba5348 
* devDeps: eslint@7.24.0->8.44.0

* devDeps: bump eslint-related to accommodate with v8

apart from typescript, which is kept at 4.6.3 despite
@metamask/eslint-config-typescript wanting ~4.8.4

* WIP: update eslint/ts config for new eslint version

* lint update

* eslint: update rules config

* eslint: update rules config

* eslint: disable @typescript-eslint/promise-function-async

* eslint: disable jsdoc/match-description

* eslint: disable @typescript-eslint/prefer-nullish-coalescing

* eslint: disable @typescript-eslint/unbound-method

* eslintrc fix typo

* eslint: disable @typescript-eslint/prefer-reduce-type-parameter

* eslint: disable id-denylist

* lint:fix

* Update packages/base-controller/src/BaseControllerV2.ts

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* eslintrc: remove redundant rules

* lint tests,scripts

* remove redundant parserOptions

* Update .eslintrc.js

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@legobeat @Gudahtt @MajorLift
devDeps: update eslint packages (#1498)
9e0a36b 
* devDeps: eslint@7.24.0->8.44.0

* devDeps: bump eslint-related to accommodate with v8

apart from typescript, which is kept at 4.6.3 despite
@metamask/eslint-config-typescript wanting ~4.8.4

* WIP: update eslint/ts config for new eslint version

* lint update

* eslint: update rules config

* eslint: update rules config

* eslint: disable @typescript-eslint/promise-function-async

* eslint: disable jsdoc/match-description

* eslint: disable @typescript-eslint/prefer-nullish-coalescing

* eslint: disable @typescript-eslint/unbound-method

* eslintrc fix typo

* eslint: disable @typescript-eslint/prefer-reduce-type-parameter

* eslint: disable id-denylist

* lint:fix

* Update packages/base-controller/src/BaseControllerV2.ts

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* eslintrc: remove redundant rules

* lint tests,scripts

* remove redundant parserOptions

* Update .eslintrc.js

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FrederikBolding FrederikBolding FrederikBolding approved these changes

@Gudahtt Gudahtt Gudahtt approved these changes

+1 more reviewer

@darkwing darkwing darkwing approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@legobeat @Gudahtt @darkwing @FrederikBolding