devDeps: upgrade eslint & friends#1277
Conversation
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
|
@mcmire Yes, it's an ongoing attempt at redoing the same effort from scratch with less changes to code. |
mcmire
left a comment
There was a problem hiding this comment.
Would love to see this merged! Left a couple of comments.
| { | ||
| files: ['*.js'], | ||
| parserOptions: { | ||
| project: ['./tsconfig.packages.json'], |
There was a problem hiding this comment.
Hmm. tsconfig.packages.json is intended to be the parent for each package-level tsconfig, so using it directly like this seems wrong to me. Was there a reason why the root tsconfig file doesn't work?
tsconfig.json
Outdated
| "strictNullChecks": true | ||
| }, | ||
| "parserOptions": { | ||
| "project": ["./tsconfig.json"] |
There was a problem hiding this comment.
Did you mean to put this in .eslintrc.js?
|
0583489 to
d189c23
Compare
This reverts commit da0e1f2.
|
Closed in favor of #1498, which retains the same |
Description
Changes
eslint@7.24.0->8.39.0// TODOReferences
Checklist