This repository was archived by the owner on Oct 7, 2024. It is now read-only.
Fixed a typo in the duplicate account import error#153
Merged
Gudahtt merged 2 commits intoMetaMask:mainfrom Nov 3, 2022
Merged
Fixed a typo in the duplicate account import error#153Gudahtt merged 2 commits intoMetaMask:mainfrom
Gudahtt merged 2 commits intoMetaMask:mainfrom
Conversation
6 tasks
Changed quotations to please the linter
Member
|
This looks great, thanks! There is a lint error that you should be able to resolve by installing dependencies and running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today when I was using MetaMask I noticed that the following unlocalized typo gets surfaced to end users who attempt to import a duplicate account. This PR simply fixes the typo, thus fixing the MetaMask issue MetaMask/metamask-extension#16370. Merging this pull request will break a downstream MetaMask test case that expects the typo, so I have also fixed the test case separately in the pull request MetaMask/metamask-extension#16371.