Fixed a duplicate account import test case relying on an upstream typo#16371
Closed
TimTinkers wants to merge 3 commits intoMetaMask:developfrom
Closed
Fixed a duplicate account import test case relying on an upstream typo#16371TimTinkers wants to merge 3 commits intoMetaMask:developfrom
TimTinkers wants to merge 3 commits intoMetaMask:developfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Updated quotations to please the linter
Contributor
|
This was merged with #15558 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This pull request in the upstream KeyringController MetaMask/KeyringController#153 fixes the issue #16370.
This current pull request fixes a test case such that the upstream KeyringController fix can be used.
Currently, users encounter a typo when attempting to import a duplicate account into MetaMask. The typo is not localized and originates from the upstream KeyringController. I have submitted a pull request here MetaMask/KeyringController#153 to fix the typo, but doing so would break a test case in this repository which expects the typo. This pull request fixes the test case such that it will expect the typo-free error from KeyringController. This pull request should be merged after MetaMask/KeyringController#153 because it is dependent on the typo being fixed there.
More Information
I encountered this typo when attempting to import an account via its private key after that account had previously already been imported.
Screenshots/Screencaps
Before
After
The UI will look the same until after MetaMask/KeyringController#153 is merged and incorporated. After that point, the end user will no longer see the "you're are" typo and will just see "you are".
Manual Testing Steps
You can verify that this issue is present by importing an account from private key and then attempting to import the same account. You should no longer see the typo if using the new KeyringController.
Pre-Merge Checklist
+ If there are functional changes: