Skip to content

[development] Remove DHM module#9972

Merged
ronald-cron-arm merged 12 commits intoMbed-TLS:developmentfrom
valeriosetti:issue9956-development
Mar 7, 2025
Merged

[development] Remove DHM module#9972
ronald-cron-arm merged 12 commits intoMbed-TLS:developmentfrom
valeriosetti:issue9956-development

Conversation

@valeriosetti
Copy link
Copy Markdown
Contributor

@valeriosetti valeriosetti commented Feb 12, 2025 •
edited by ronald-cron-arm
Loading

Description

Resolves #9956

This PR depends on:

PR checklist

  • changelog done
  • development PR not required because: it's this one
  • TF-PSA-Crypto PR provided [tf-psa-crypto] Remove DHM module TF-PSA-Crypto#175
  • framework PR not needed
  • 3.6 PR not required
  • 2.28 PR not required
  • tests provided: we're removing support in this PR, so we're mostly removing tests here instead of adding them.

This was referenced Feb 12, 2025
Closed
Merged
@valeriosetti valeriosetti self-assigned this Feb 12, 2025
@valeriosetti valeriosetti added needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review size-s Estimated task size: small (~2d) priority-high High priority - will be reviewed soon labels Feb 12, 2025
@valeriosetti
Copy link
Copy Markdown
Contributor Author

valeriosetti commented Feb 13, 2025

I checked ABI-API failures and they look reasonable to me for this kind of PR.

Harry-Ramsey
Harry-Ramsey previously approved these changes Feb 13, 2025
View reviewed changes
@valeriosetti valeriosetti removed the needs-ci Needs to pass CI tests label Feb 14, 2025
Harry-Ramsey
Harry-Ramsey previously approved these changes Feb 16, 2025
View reviewed changes
ronald-cron-arm
ronald-cron-arm requested changes Feb 17, 2025
View reviewed changes
@valeriosetti valeriosetti added the needs-preceding-pr Requires another PR to be merged first label Feb 17, 2025
@valeriosetti valeriosetti removed needs-preceding-pr Requires another PR to be merged first needs-reviewer This PR needs someone to pick it up for review labels Feb 24, 2025
Harry-Ramsey
Harry-Ramsey previously approved these changes Feb 27, 2025
View reviewed changes
ronald-cron-arm
ronald-cron-arm requested changes Mar 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks almost good to me, only some minor comments, thanks.

@valeriosetti valeriosetti force-pushed the issue9956-development branch 2 times, most recently from ce4ad81 to 76e6195 Compare March 4, 2025 09:29
@valeriosetti
scripts: generate_errors: remove DHM occurrence
ddc4b04 
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
@valeriosetti
library: do not include dhm.c in the build
d7a4654 
The file was cancelled from the tf-psa-crypto repo following the removal
of MBEDTLS_DHM_C.

Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
@valeriosetti
docs: remove references to DHM
28c645b 
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
@valeriosetti
ChangeLog: add note for removal of DHM related functions in SSL
05c23fb 
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
@valeriosetti valeriosetti force-pushed the issue9956-development branch from f0f9f0d to d9950fe Compare March 5, 2025 09:11
Harry-Ramsey
Harry-Ramsey previously approved these changes Mar 5, 2025
View reviewed changes
@valeriosetti valeriosetti force-pushed the issue9956-development branch from d9950fe to 099cc5c Compare March 6, 2025 10:18
@valeriosetti valeriosetti force-pushed the issue9956-development branch from 099cc5c to 39f63d7 Compare March 6, 2025 14:58
ronald-cron-arm
ronald-cron-arm previously approved these changes Mar 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Harry-Ramsey
Harry-Ramsey previously approved these changes Mar 6, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this from In Development to Has Approval in Roadmap pull requests (new board) Mar 6, 2025
@valeriosetti
tf-psa-crypto: udpate reference
692d855 
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
@valeriosetti valeriosetti force-pushed the issue9956-development branch from 39f63d7 to 692d855 Compare March 7, 2025 08:57
ronald-cron-arm
ronald-cron-arm approved these changes Mar 7, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@ronald-cron-arm
Copy link
Copy Markdown
Contributor

ronald-cron-arm commented Mar 7, 2025

@Harry-Ramsey please have a look to the last TF-PSA-Crypto pointer update such that this PR can be added to the merge queue, thanks.

@ronald-cron-arm ronald-cron-arm disabled auto-merge March 7, 2025 12:50
@ronald-cron-arm ronald-cron-arm added this pull request to the merge queue Mar 7, 2025
Merged via the queue into Mbed-TLS:development with commit 0ef4184 Mar 7, 2025
4 of 6 checks passed
@github-project-automation github-project-automation bot moved this from Has Approval to Done in Roadmap pull requests (new board) Mar 7, 2025
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Dec 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gilles-peskine-arm gilles-peskine-arm gilles-peskine-arm left review comments

@ronald-cron-arm ronald-cron-arm ronald-cron-arm approved these changes

+1 more reviewer

@Harry-Ramsey Harry-Ramsey Harry-Ramsey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@valeriosetti valeriosetti

Labels

needs-review Every commit must be reviewed by at least two team members, priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)

Projects

Roadmap pull requests (new board)
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove DHM module

4 participants

@valeriosetti @ronald-cron-arm @gilles-peskine-arm @Harry-Ramsey