Skip to content

[development] Move benchmark program to TF-PSA-Crypto#9986

Merged
ronald-cron-arm merged 4 commits intoMbed-TLS:developmentfrom
valeriosetti:issue9971-development
Feb 21, 2025
Merged

[development] Move benchmark program to TF-PSA-Crypto#9986
ronald-cron-arm merged 4 commits intoMbed-TLS:developmentfrom
valeriosetti:issue9971-development

Conversation

@valeriosetti
Copy link
Copy Markdown
Contributor

@valeriosetti valeriosetti commented Feb 17, 2025

Description

Resolves #9971

PR checklist

@valeriosetti valeriosetti self-assigned this Feb 17, 2025
@valeriosetti valeriosetti added needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most) labels Feb 17, 2025
Harry-Ramsey
Harry-Ramsey previously approved these changes Feb 17, 2025
@valeriosetti valeriosetti force-pushed the issue9971-development branch 2 times, most recently from 2cc5ce4 to b247142 Compare February 19, 2025 10:45
Copy link
Copy Markdown
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Harry-Ramsey
Harry-Ramsey previously approved these changes Feb 21, 2025
ronald-cron-arm added a commit to Mbed-TLS/TF-PSA-Crypto that referenced this pull request Feb 21, 2025
 [tf-psa-crypto] Move benchmark program to TF-PSA-Crypto
This PR cannot be validated by the TF-PSA-Crypto CI as it is incompatible with mbedtls:development. It has been validated by the CI of Mbed-TLS/mbedtls#9986 thus I am merging it.
@valeriosetti valeriosetti force-pushed the issue9971-development branch 2 times, most recently from 1efc808 to bd9e5d4 Compare February 21, 2025 09:01
@ronald-cron-arm ronald-cron-arm removed the needs-reviewer This PR needs someone to pick it up for review label Feb 21, 2025
Copy link
Copy Markdown
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This commit also removes references from Makefile and README.md.

Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
Remove entry for benchmark program since it was moved to the tf-psa-crypto
repo.

Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
Since benchmark programs was moved to tf-psa-crypto, this script should
be moved as well.

Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
Copy link
Copy Markdown
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@ronald-cron-arm ronald-cron-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Feb 21, 2025
@ronald-cron-arm ronald-cron-arm added this pull request to the merge queue Feb 21, 2025
Merged via the queue into Mbed-TLS:development with commit ede8494 Feb 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Design and code approved - may be waiting for CI or backports priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most)

Development

Successfully merging this pull request may close these issues.

Move benchmark program to TF-PSA-Crypto

3 participants