[tf-psa-crypto] Remove DHM module#175
Merged
ronald-cron-arm merged 6 commits intoMbed-TLS:developmentfrom Mar 6, 2025
Merged
Conversation
This was referenced Feb 12, 2025
af96d0a to
3ce6496
Compare
Harry-Ramsey
previously approved these changes
Feb 13, 2025
3ce6496 to
b1706aa
Compare
Harry-Ramsey
previously approved these changes
Feb 16, 2025
b1706aa to
ce5d878
Compare
Contributor
Author
|
I'm removing the |
Harry-Ramsey
previously approved these changes
Feb 27, 2025
ronald-cron-arm
requested changes
Mar 4, 2025
Contributor
ronald-cron-arm
left a comment
There was a problem hiding this comment.
This looks almost good to me, only some minor comments, thanks.
ce5d878 to
47c19d0
Compare
47c19d0 to
34dfe6d
Compare
MBEDTLS_DHM_C is being removed so related test suites can be removed as well. Signed-off-by: Valerio Setti <vsetti@baylibre.com>
34dfe6d to
c2ebd20
Compare
Harry-Ramsey
previously approved these changes
Mar 5, 2025
Contributor
ronald-cron-arm
left a comment
There was a problem hiding this comment.
This looks almost good to me, just one thing why not merging psa_crypto_ffdh_params.h into psa_crypto_ffdh.h? I do not see why we would need two files.
Contributor
Author
|
c2ebd20 to
5b0767e
Compare
ronald-cron-arm
requested changes
Mar 6, 2025
Contributor
ronald-cron-arm
left a comment
There was a problem hiding this comment.
One last thing otherwise it looks good to me, thanks.
Standardized DH groups which were defined in dhm.h have been moved to psa_crypto_ffdh_params.h. These are used by the psa_crypto_ffdh.c file internally only. Signed-off-by: Valerio Setti <vsetti@baylibre.com>
This commit also removes references to DHM module in the documentation of other symbols in crypto_config.h. Signed-off-by: Valerio Setti <vsetti@baylibre.com>
Signed-off-by: Valerio Setti <vsetti@baylibre.com>
Signed-off-by: Valerio Setti <vsetti@baylibre.com>
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
5b0767e to
8042139
Compare
Harry-Ramsey
approved these changes
Mar 6, 2025
Contributor
|
PR validated by the CI of #9972. Ready to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Helps resolving Mbed-TLS/mbedtls#9956
This PR introduces changes which are incompatible if tested with
developmentbranch of the main Mbed-TLS repo. Please use CI of Mbed-TLS/mbedtls#9972 to check if changes here are OK or not.PR checklist