Merged
Conversation
- Removes precompiler directives that provided support for Qt versions prior to this threshold. - Apply this requirement both during configure script and during build of GUI commands.
jdtournier
approved these changes
Sep 14, 2020
Member
jdtournier
left a comment
There was a problem hiding this comment.
Seems to work fine on my Arch system. But then it's running Qt 5.15, and it's hard to force Qt4 back onto it, so I can't realistically check how it handles a Qt4 system.
But then, the main thing is that it still works with Qt >= 5.5, and tries to prevent the use of older versions, so it's all good as far as I'm concerned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second half of #2142: where the first half (#2153) only alters documentation on
master, this goes todev, and involves removing support for anything prior to 5.5 and performing corresponding checks.