Skip to content

Docs: State Qt5 as GUI requirement#2153

Merged
jdtournier merged 4 commits intomasterfrom
docs_qt5
Sep 9, 2020
Merged

Docs: State Qt5 as GUI requirement#2153
jdtournier merged 4 commits intomasterfrom
docs_qt5

Conversation

@Lestropie
Copy link
Copy Markdown
Member

As described in #2142.

I have some recollection of a discussion where Qt 5.05 would be a more specific minimum requirement; anyone recall?

@Lestropie Lestropie self-assigned this Sep 2, 2020
@Lestropie Lestropie added this to the 3.0.2 hotfix milestone Sep 2, 2020
@Lestropie Lestropie requested a review from a team September 2, 2020 09:11
The code will still compile with Qt4; this is only a change to the documentation to more strongly dissuade Qt4 usage, with the intention of removing Qt4 support in a future micro update.
@jdtournier
Copy link
Copy Markdown
Member

Yes, that rings a bell. I think it might have been to do with this being the minimum version that works for macOS. @bjeurissen might be able to give the specifics, I must admit I can't remember...

@bjeurissen
Copy link
Copy Markdown
Member

I can only remember #2120 where I argued that Qt >=5.5 should be available in all versions of popular linux distributions that are realistically still being used.

That said, there might be reasons to opt for more recent qt versions, e.g. better hdpi support or better dark mode support, ... But as long as it compiles and works properly, I think we can deem it supported..

So I would just look at the oldest linux distribution versions that are still supported by their maintainers and see what Qt version they package to decide a minimal requirement. At least then we are sure it will work out of the box on popular distributions.

@Lestropie
Copy link
Copy Markdown
Member Author

There's a lot of precompiler directives for Qt >= 5.4, and one for 5.5. I reckon given it's hard to find anything less than 5.5, we should just state that we expect that, and then for 3.1.0 we can remove all of those directives.

@jdtournier
Copy link
Copy Markdown
Member

jdtournier commented Sep 3, 2020

I'm happy enough to mandate Qt≥5.5, it will simplify the OpenGL handling substantially (that's what a lot of those directives will relate to).

We'd need to update the Qt checks in the configure script, and I'dd probably add a compile time check in there somewhere, probably in src/gui/opengl/gl.h (which is included pretty much everywhere GUI related), of the form:

#if QT_VERSION < 0x050500
# error "MRtrix requires Qt version 5.5 or later"
#endif 

@Lestropie Lestropie mentioned this pull request Sep 4, 2020
@jdtournier jdtournier merged commit 7964bd5 into master Sep 9, 2020
@jdtournier jdtournier deleted the docs_qt5 branch September 9, 2020 07:32
@Lestropie Lestropie mentioned this pull request Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants