Migrate build from rollup to rolldown#10011
Conversation
|
Here's how the bundle sizes change: |
|
I am a big supporter of using Rolldown, it is much faster! Couple of notes though:
|
|
@simon04 I'm going to do a quick squash and add some of the discussed changes so we can get this merged in. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
So I have been doing some digging, and it seems that the bundle that is currently emitted by Rollup (on |
|
@simon04 I had to do some fixes to the original Rollup build (see #10027, #10028, #10029) to make sure all the various distributions work correctly. It looks like Rolldown might not support all the options required to make this work (yet), specifically the Even without Rolldown, I think this PR has some valuable additions, so I will be splitting the chunks of the work you have done here into separate PRs that we can land individually. |
|
@IvanSanchez I've removed You might want to deprecate |
Co-authored-by: Simon Legner <Simon.Legner@gmail.com>
|
@simon04 I have split out the work you did here, and some other enhancements into separate PRs that have landed on Looking at the final build, it seems that Rolldown is missing several features that would have to be implemented in order for this PR to be merged, namely:
|
|
Hi @jonkoops, amazing, thank you for your work. Considering that builds are performed only so often, and that the rollup build is sufficiently fast (914ms on an Intel i5-14600K), I think we can de-prioritize the migration to rolldown. |
|
Agreed, it would still be nice to move in the future once these features are implemented. I believe the goal is to be fully Rollup compatible in the long run, so it should 'just work' in the long run. It would be nice if someone could report these compatibility issues on their repo, and add them here for tracking. I am currently too tied down on other stuff to do so 😉 |
|
I've submitted the following upstream feature requests: |
|
Appreciate it! |
https://rolldown.rs/