Remove default export from ESM distribution#10029
Merged
Merged
Conversation
Signed-off-by: Jon Koops <jonkoops@gmail.com>
Collaborator
Author
|
@Leaflet/core @Leaflet/leaflet-maintainers could I get a review for this one so I can continue fixing up the build? |
Collaborator
Author
|
I am going to bypass the review and just get this in, I want to start making some progress on the last impediments here. If there are any latent comments, do let me know, and I will address them in a separate PR. |
This was referenced Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the default
Lexport from the ESM distribution, opting for named exports only. This makes it easier to tree-shake code that is imported from the package in the future. This also freezes the ESM distribution, so exported modules cannot be modified, which is expected for modules, and prevents side effects from being introduced by external code.The UMD distribution is unaffected, and still allows external code to modify the
Lnamespace and its members, and still exposes theLglobal.This PR is a split off from #10027 and #9880.