Skip to content

[Chore][Docs] Stale MP CLI and Flags#2882

Merged
sammshen merged 1 commit intoLMCache:devfrom
sammshen:cleanup-mp-documentation
Mar 27, 2026
Merged

[Chore][Docs] Stale MP CLI and Flags#2882
sammshen merged 1 commit intoLMCache:devfrom
sammshen:cleanup-mp-documentation

Conversation

@sammshen
Copy link
Copy Markdown
Contributor

No description provided.

- --http-port default is 8080, not 8000
- --l2-store-policy choice is 'skip_l1', not 'noop'
- blend_server.py renamed to blend_server_v2.py
- use 'lmcache server' consistently instead of 'python3 -m' for non-Docker examples
- reorder server variants table to list recommended entry point first
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation to reflect architectural and configuration changes in the LMCache multiprocess server. Key updates include renaming 'blend_server.py' to 'blend_server_v2.py', changing the default HTTP port from 8000 to 8080, and renaming the 'noop' L2 store policy to 'skip_l1'. The documentation also shifts focus toward the 'lmcache server' entry point as the recommended usage and adds details for the '/api/clear-cache' and '/api/status' endpoints. I have no feedback to provide as there were no review comments to assess.

@sammshen sammshen enabled auto-merge (squash) March 26, 2026 20:10
Copy link
Copy Markdown
Contributor

@ApostaC ApostaC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM!

- Store all keys to all adapters. Never delete from L1.
* - ``--l2-store-policy``
- ``noop``
- ``skip_l1``
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is fixed in #2869

@sammshen sammshen added the full Run comprehensive tests on this PR label Mar 26, 2026
@sammshen sammshen changed the title [Docs] Stale MP CLI and Flags [Chore][Docs] Stale MP CLI and Flags Mar 26, 2026
@sammshen sammshen merged commit 85a333a into LMCache:dev Mar 27, 2026
34 checks passed
jooho-XCENA pushed a commit to xcena-dev/LMCache that referenced this pull request Apr 2, 2026
fix incorrect defaults, flags, and entry points in MP documentation

- --http-port default is 8080, not 8000
- --l2-store-policy choice is 'skip_l1', not 'noop'
- blend_server.py renamed to blend_server_v2.py
- use 'lmcache server' consistently instead of 'python3 -m' for non-Docker examples
- reorder server variants table to list recommended entry point first
jooho-XCENA pushed a commit to xcena-dev/LMCache that referenced this pull request Apr 2, 2026
fix incorrect defaults, flags, and entry points in MP documentation

- --http-port default is 8080, not 8000
- --l2-store-policy choice is 'skip_l1', not 'noop'
- blend_server.py renamed to blend_server_v2.py
- use 'lmcache server' consistently instead of 'python3 -m' for non-Docker examples
- reorder server variants table to list recommended entry point first
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full Run comprehensive tests on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants