Skip to content

[Chore][Docs] Fix mp docs for store policy: skip_l1#2869

Merged
ApostaC merged 1 commit intoLMCache:devfrom
ApostaC:local-dev/doc-fix-mar25
Mar 26, 2026
Merged

[Chore][Docs] Fix mp docs for store policy: skip_l1#2869
ApostaC merged 1 commit intoLMCache:devfrom
ApostaC:local-dev/doc-fix-mar25

Conversation

@ApostaC
Copy link
Copy Markdown
Contributor

@ApostaC ApostaC commented Mar 25, 2026

What this PR does / why we need it:

Fixes documentation references to the renamed L2 store policy. The noop store policy was renamed to skip_l1 but the docs still referenced the old name in configuration.rst and l2_storage.rst.

Special notes for your reviewers:

Docs-only change — no code modifications.

If applicable:

  • this PR contains user facing changes - docs added
  • this PR contains unit tests

Signed-off-by: ApostaC <yihua98@uchicago.edu>
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the accuracy and consistency of the project's documentation. It addresses outdated references to an L2 store policy that was recently renamed, ensuring that users and developers consult up-to-date information regarding L2 storage configurations, especially for the buffer-only mode.

Highlights

  • Documentation Update: Updated all references to the noop L2 store policy to skip_l1 in the configuration.rst and l2_storage.rst documentation files to reflect a recent rename.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames the noop policy for the --l2-store-policy option to skip_l1 across the documentation files docs/source/mp/configuration.rst and docs/source/mp/l2_storage.rst. This includes updating the policy description, available choices, and example usage to reflect the new name. I have no feedback to provide.

Copy link
Copy Markdown
Contributor

@sammshen sammshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ApostaC ApostaC enabled auto-merge (squash) March 25, 2026 23:38
@ApostaC ApostaC added the full Run comprehensive tests on this PR label Mar 25, 2026
@ApostaC ApostaC merged commit e70a700 into LMCache:dev Mar 26, 2026
42 of 44 checks passed
jooho-XCENA pushed a commit to xcena-dev/LMCache that referenced this pull request Apr 2, 2026
[add] doc fix for l2 store policy
Signed-off-by: ApostaC <yihua98@uchicago.edu>
jooho-XCENA pushed a commit to xcena-dev/LMCache that referenced this pull request Apr 2, 2026
[add] doc fix for l2 store policy
Signed-off-by: ApostaC <yihua98@uchicago.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full Run comprehensive tests on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants