Skip to content

0.3.0#194

Merged
ca333 merged 15 commits intomasterfrom
dev
Aug 31, 2020
Merged

0.3.0#194
ca333 merged 15 commits intomasterfrom
dev

Conversation

@ca333
Copy link
Copy Markdown
Contributor

@ca333 ca333 commented Aug 25, 2020

No description provided.

phm87 and others added 15 commits December 16, 2019 19:43
I had a bug on the main Notary Node (NN) but it didn't happen on the 3P NN on KMD.
If there is only one "iguana" UTXO and no other UTXO (*), no notarization happens and the following error happens:
```no (%s -> %s) utxo: need to fund address.(%s) or wait for splitfund to confirm\n```

(*) Such case can be encountered if the node is running out of assetchain balance and there is only one "iguana" UTXO left. it can also happens if playing with distant coin split and/or advanced use of wallet filters.


In such a case, the loop inside dpow_haveutxo will have ``n = cJSON_GetArraySize(unspents) = 1`` because listunspent returns only one UTXO. As ``j`` variable is initialized at 0 before the loop and incremented at the beginning of the loop, j = 1 at the first iteration of the loop so j = n and the loop will exit. By moving the j incrementation at the end of the loop, it will execute the code within the loop if there is only one UTXO.

To test/analyse:
- add more logs and analyze iguana TV on main NN and 3P NN.

To test:
- Test with different coinsplit scripts,
- Test with distant coinsplit (e.g. with https://github.com/DeckerSU/komodo_scripts/blob/master/split_nn_sapling.sh) with/without wallet filters
- Test on main NN and 3P NN in different situations (no coin left, only one big utxo not splitted, same tests without sapling (OOT)).

Changelog for NN operators:
The number of the chosen UTXO will be decreased by 1, meaning the UTXO "numbering" in the log will start at UTXO 0 instead of starting from UTXO 1:
[%s] : chosen = %d  out of %d loop.(%d)\n
This should give time for rule clarity and tweaking of processes etc to avoid unintended mass culling of the NN group while initial rule-sets are scrutinized, adapted and more explicitly defined with respect to actual conditions within the network.
For example - `Reach at least 33% of your region’s best monthly NN notarization score. This is checked on the first day of each month, beginning one month after the new NN season has begun.` has been tagged for review due to early notarisation figures indicating skewed distribution (e.g. in SH region, #1 node has 2x score of #2 node)
I'd encourage NN ops to discuss a revised metric and submit it in accordance with the "polls and voting" section of the NN bible.
Add provisions for early season grace period.
dpow_haveutxo: fix bug if only one "iguana" UTXO
iguana_payments.c : signrawtransaction : enhance log
Chips adaptivePoW Hard Fork at block 6874120, around 3rd Sep
@ca333 ca333 marked this pull request as ready for review August 31, 2020 12:08
@ca333 ca333 requested a review from tonymorony August 31, 2020 12:08
@tonymorony tonymorony self-requested a review August 31, 2020 13:44
@ca333 ca333 merged commit 13d473a into master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants