Skip to content

Update build system to support building against VTK9#84

Merged
cpinter merged 2 commits intomasterfrom
82-update-buildsystem-to-support-vtk9
Jun 30, 2021
Merged

Update build system to support building against VTK9#84
cpinter merged 2 commits intomasterfrom
82-update-buildsystem-to-support-vtk9

Conversation

@jcfr
Copy link
Contributor

@jcfr jcfr commented Jun 29, 2021

  • Update SuperBuild.cmake to fetch sources of VTKExternalModule project.

  • Split VTKRenderingOpenVR external project to configure and build
    the OpenVR sources using VTKExternalModule buildsystem.

  • Rename OPENVR_* variables to OpenVR_*.

  • Update packaging rules to install "runtime" and "python" components.

  • Fix build issues

jcfr added 2 commits June 29, 2021 05:30
* Update SuperBuild.cmake to fetch sources of VTKExternalModule project.

* Split VTKRenderingOpenVR external project to configure and build
  the OpenVR sources using VTKExternalModule buildsystem.

* Rename OPENVR_* variables to OpenVR_*.

* Update packaging rules to install "runtime" and "python" components.
@jcfr jcfr linked an issue Jun 29, 2021 that may be closed by this pull request
@jcfr jcfr requested review from adamrankin and cpinter June 29, 2021 10:24
@adamrankin
Copy link
Collaborator

Even with the external module project, a number of files are generated inside the source directory using VS2019. It's not really a problem, just sub-optimal.

@adamrankin
Copy link
Collaborator

image

@jcfr
Copy link
Contributor Author

jcfr commented Jun 29, 2021

a number of files are generated inside the source directory using VS2019. It's not really a problem, just sub-optimal.

Thanks for reporting this. This can be observed independently of the generator, I am currently working on a VTK patch to address the issue.

@jcfr
Copy link
Contributor Author

jcfr commented Jun 29, 2021

currently working on a VTK patch to address the issue.

See https://gitlab.kitware.com/vtk/vtk/-/merge_requests/8123

I will also backport the change into our Slicer/VTK fork

@jcfr
Copy link
Contributor Author

jcfr commented Jun 29, 2021

backport the change into our Slicer/VTK fork

Here it is: Slicer/Slicer#5714

@adamrankin
Copy link
Collaborator

Building now, will report back

@jcfr
Copy link
Contributor Author

jcfr commented Jun 30, 2021

I identified one issue that I will be fixing shorty.

Update: With a clean build of the extension, there are no issues.

Copy link
Collaborator

@cpinter cpinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the build as well and it seems to work well. I'm not saying I understand how VTKExternalModule works exactly, but it does :) Thank you!

Copy link
Collaborator

@adamrankin adamrankin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build works for me!

@cpinter cpinter merged commit 22c995b into master Jun 30, 2021
@jcfr jcfr deleted the 82-update-buildsystem-to-support-vtk9 branch June 30, 2021 15:51
jcfr added a commit to Slicer/ExtensionsIndex that referenced this pull request Jun 30, 2021
jcfr added a commit to Slicer/ExtensionsIndex that referenced this pull request Jun 30, 2021
jcfr added a commit to Slicer/ExtensionsIndex that referenced this pull request Jul 2, 2021
@jcfr jcfr mentioned this pull request Oct 13, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to new VTK module system

3 participants