COMP: Update VTK to improve support for extension bundling VTK modules#5714
Merged
jcfr merged 1 commit intoSlicer:masterfrom Jun 29, 2021
Conversation
VTK modules can be built in the following scenarios:
1. Module sources and generated buildsystem are respectively in VTK source and build trees (aka built-in case)
2. Module sources are external and module generated buildsystem is in VTK build tree (aka built-in case for a VTK remote module)
3. Module sources and module generated buildsystem are both external
4. Module sources are in VTK source tree and module generated buildsystem is external
This commit updates VTK to include logic ensuring files are not generated
in VTK source for case (3) and (4).
List of changes:
$ git shortlog f3c1a72fbf..fe57670c3e --no-merges
Jean-Christophe Fillion-Robin (1):
[Backport MR-8123] Do not generate files in source tree when building module externally
Member
Author
|
After additional testing, this will likely need an additional tweak. |
Member
Author
With a clean build of the extension, there are no issues. |
Member
|
This is great @jcfr , thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VTK modules can be built in the following scenarios:
This commit updates VTK to include logic ensuring files are not generated
in VTK source for case (3) and (4).
List of changes: