Skip to content

Validate heap is bound#11693

Merged
spencer-lunarg merged 3 commits intoKhronosGroup:mainfrom
spencer-lunarg:x11692
Feb 17, 2026
Merged

Validate heap is bound#11693
spencer-lunarg merged 3 commits intoKhronosGroup:mainfrom
spencer-lunarg:x11692

Conversation

@spencer-lunarg
Copy link
Copy Markdown
Contributor

closes #11688 (built on top of #11692)

@spencer-lunarg spencer-lunarg requested a review from a team as a code owner February 17, 2026 04:51
@ci-tester-lunarg
Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 651149.

return vvl::DescriptorModeClassic;
}

std::string LastBound::DescribeInvalidDescriptorMode() const {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provides error messages like

vkCmdDispatch(): SPIR-V (GLCompute) uses [Set 0, Binding 0, variable "A"], but a resource heap was not bound (with vkCmdBindResourceHeapEXT).

The command buffer is currently in 'Classic Descriptor' mode from previous call to vkCmdBindDescriptorSets which invalidated the previous 'Descriptor Heap' mode that was set with vkCmdBindResourceHeapEXT.

or

The command buffer is currently in 'Descriptor Heap' mode from previous call to vkCmdPushDataEXT which invalidated the previous 'Classic Descriptor' mode that was set with vkCmdPushConstants.

which was REALLY nice to find a test that was doing that on us

@ci-tester-lunarg
Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build # 22499 running.

@ci-tester-lunarg
Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build # 22499 failed.

@ci-tester-lunarg
Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 651467.

@ci-tester-lunarg
Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build # 22500 running.

@ci-tester-lunarg
Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build # 22500 passed.

@spencer-lunarg spencer-lunarg merged commit 7249a21 into KhronosGroup:main Feb 17, 2026
22 checks passed
@spencer-lunarg spencer-lunarg deleted the x11692 branch February 17, 2026 13:23
arno-lunarg pushed a commit to arno-lunarg/Vulkan-ValidationLayers that referenced this pull request Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing validation for descriptor heap / pre-heap binding clobber

3 participants