Closed
Conversation
Collaborator
|
CI Vulkan-ValidationLayers build queued with queue ID 651072. |
e107639 to
2f55038
Compare
Collaborator
|
CI Vulkan-ValidationLayers build queued with queue ID 651085. |
Collaborator
|
CI Vulkan-ValidationLayers build # 22497 running. |
| return skip; | ||
| } | ||
| const char *msg = descriptor_mode != vvl::DescriptorModeUnknown | ||
| ? " (The command buffer has called vkCmdBindDescriptorSets, vkCmdBindDescriptorSets2, vkCmdPushConstants " |
Contributor
There was a problem hiding this comment.
could you add a test that does Descriptor Buffer and Heaps (imagine if someone is porting from buffers to heap and mixing things in the command buffer)
2f55038 to
0e9b56b
Compare
Collaborator
|
CI Vulkan-ValidationLayers build queued with queue ID 651103. |
Collaborator
|
CI Vulkan-ValidationLayers build # 22498 running. |
Collaborator
|
CI Vulkan-ValidationLayers build # 22498 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11688