Skip to content

spirv-fuzz: Create a helper in fuzzerutil to reuse function type#3572

Merged
afd merged 4 commits intoKhronosGroup:masterfrom
Vasniktel:reuse_function_type
Jul 23, 2020
Merged

spirv-fuzz: Create a helper in fuzzerutil to reuse function type#3572
afd merged 4 commits intoKhronosGroup:masterfrom
Vasniktel:reuse_function_type

Conversation

@Vasniktel
Copy link
Copy Markdown
Collaborator

Fixes #3534.

Copy link
Copy Markdown
Contributor

@afd afd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some changes requested.

@Vasniktel Vasniktel requested a review from afd July 22, 2020 13:02
@afd afd added the kokoro:run label Jul 22, 2020
Copy link
Copy Markdown
Contributor

@afd afd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. I left a couple of comments on variable naming that I recommend making but don't insist on.

There's one thing I don't like about this: suppose that f's current type has only 1 user, but the new type for f already exists. In that case we add the new type to the module and change f so it has that type, but we leave the old type in the module even though it has no users.

I feel like it would be more natural to remove the old type in that case. What do you think @Vasniktel ? Perhaps I am over-thinking it - it would be unlikely to arise.

@Vasniktel Vasniktel requested a review from afd July 22, 2020 14:53
Copy link
Copy Markdown
Contributor

@afd afd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@afd afd added the kokoro:run label Jul 23, 2020
@afd afd merged commit 1aaf5c6 into KhronosGroup:master Jul 23, 2020
@Vasniktel Vasniktel deleted the reuse_function_type branch July 24, 2020 08:50
dneto0 added a commit to dneto0/SPIRV-Tools that referenced this pull request Sep 14, 2024
KhronosGroup/glslang@9eef54b...3ee5f2f

$ git log 9eef54b..3ee5f2f --date=short --no-merges --format='%ad %ae %s'
2020-07-22 greg Update spirv-tools known-good to most recent stable
2020-07-19 vkushwaha Add changes for SPV_EXT_shader_atomic_float_add
2020-07-14 bclayton Limit visibility of symbols for internal libraries
2020-07-20 john SPV: Update to the latest SPIR-V headers.
2020-07-14 bclayton Deprecate InitializeDll functions
2020-07-14 bclayton Simplify PoolAlloc with use of thread_local.
2020-07-14 malcolm also search global variables assignment for live variables
2020-07-20 bclayton Drop support for VS2013
2020-07-20 bclayton Start glslang 11.0.0
2020-07-20 bclayton Finalize glslang 10.15.3847
2020-07-20 bclayton build_info: Fix parsing of versions with no flavor

Created with:
  roll-dep third_party/glslang

Roll third_party/spirv-headers/ 7f2ae11..979924c (1 commit)

KhronosGroup/SPIRV-Headers@7f2ae11...979924c

$ git log 7f2ae11..979924c --date=short --no-merges --format='%ad %ae %s'
2020-07-21 alanbaker Support SPV_KHR_terminate_invocation (KhronosGroup#163)

Created with:
  roll-dep third_party/spirv-headers

Roll third_party/spirv-tools/ c10d6ce..969f028 (18 commits)

KhronosGroup/SPIRV-Tools@c10d6ce...969f028

$ git log c10d6ce..969f028 --date=short --no-merges --format='%ad %ae %s'
2020-07-23 rharrison Change DEPS rolling script to point at external/ (KhronosGroup#3584)
2020-07-23 vasniktel spirv-fuzz: Create a helper in fuzzerutil to reuse function type (KhronosGroup#3572)
2020-07-23 vasniktel spirv-fuzz: Test usages of IdIsIrrelevant fact (KhronosGroup#3578)
2020-07-23 antonikarp spirv-fuzz: adds TransformationReplaceCopyMemoryWithLoadStore (KhronosGroup#3575)
2020-07-23 antonikarp spirv-fuzz: adds TransformationReplaceCopyObjectWithStoreLoad (KhronosGroup#3567)
2020-07-22 stevenperron Start SPIRV-Tools v2020.5
2020-07-22 stevenperron Finalize SPIRV-Tools v2020.4
2020-07-22 vasniktel spirv-fuzz: Fix usages of irrelevant constants (KhronosGroup#3566)
2020-07-22 stevenperron Update CHANGES
2020-07-22 alanbaker Support SPV_KHR_terminate_invocation (KhronosGroup#3568)
2020-07-22 stevenperron Sink pointer instructions in merge return (KhronosGroup#3569)
2020-07-21 greg Preserve OpenCL.DebugInfo.100 through elim-dead-code-aggressive (KhronosGroup#3542)
2020-07-21 vasniktel spirv-fuzz: TransformationReplaceParamsWithStruct (KhronosGroup#3455)
2020-07-21 38144211+vkushwaha-nv Add changes for SPV_EXT_shader_atomic_float (KhronosGroup#3562)
2020-07-21 vasniktel spirv-fuzz: Use irrelevant constants (KhronosGroup#3565)
2020-07-21 stefanomil spirv-fuzz: Extend TransformationRecordSynonymousConstants to allow composite constants (KhronosGroup#3537)
2020-07-21 vasniktel spirv-fuzz: Add is_irrelevant parameter (KhronosGroup#3563)
2020-07-20 vasniktel spirv-fuzz: Add IdIsIrrelevant fact (KhronosGroup#3561)

Created with:
  roll-dep third_party/spirv-tools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spirv-fuzz: Refactor boilerplate in TransformationReplaceParameter*

4 participants