Skip to content

spirv-fuzz: TransformationReplaceParamsWithStruct#3455

Merged
afd merged 18 commits intoKhronosGroup:masterfrom
Vasniktel:replace_params_with_struct
Jul 21, 2020
Merged

spirv-fuzz: TransformationReplaceParamsWithStruct#3455
afd merged 18 commits intoKhronosGroup:masterfrom
Vasniktel:replace_params_with_struct

Conversation

@Vasniktel
Copy link
Copy Markdown
Collaborator

@Vasniktel Vasniktel commented Jun 21, 2020

Fixes #3453.

@Vasniktel Vasniktel marked this pull request as draft June 21, 2020 14:21
@Vasniktel Vasniktel force-pushed the replace_params_with_struct branch 3 times, most recently from a54999a to 8f62061 Compare June 29, 2020 08:05
@Vasniktel Vasniktel force-pushed the replace_params_with_struct branch 2 times, most recently from 56f5bfa to 113eac7 Compare July 7, 2020 16:08
@Vasniktel Vasniktel force-pushed the replace_params_with_struct branch from 113eac7 to 284f207 Compare July 9, 2020 15:44
Copy link
Copy Markdown
Contributor

@afd afd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! A preliminary review with some suggested design changes.

@Vasniktel Vasniktel force-pushed the replace_params_with_struct branch from 284f207 to 9a5003e Compare July 11, 2020 10:39
@Vasniktel Vasniktel requested a review from afd July 11, 2020 10:41
Copy link
Copy Markdown
Contributor

@afd afd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on the fuzzer pass and transformation protobuf. Not a complete review - the move to maps looks good but haven't yet had time to properly scrutinise.

@Vasniktel Vasniktel force-pushed the replace_params_with_struct branch from 9a5003e to 97a33fa Compare July 13, 2020 14:02
@Vasniktel Vasniktel requested a review from afd July 13, 2020 14:04
Copy link
Copy Markdown
Contributor

@afd afd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really excellent. Some minor changes recommended - I'll be happy to merge once there are tests.

@Vasniktel Vasniktel requested a review from afd July 15, 2020 11:03
@Vasniktel Vasniktel marked this pull request as ready for review July 15, 2020 11:03
Copy link
Copy Markdown
Contributor

@afd afd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Copy Markdown
Contributor

@afd afd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Vasniktel Vasniktel force-pushed the replace_params_with_struct branch from 4bdb357 to 388517a Compare July 21, 2020 16:07
@afd afd merged commit fe9e5db into KhronosGroup:master Jul 21, 2020
dnovillo pushed a commit to dnovillo/SPIRV-Tools that referenced this pull request Aug 19, 2020
@Vasniktel Vasniktel deleted the replace_params_with_struct branch October 16, 2020 09:16
dneto0 added a commit to dneto0/SPIRV-Tools that referenced this pull request Sep 14, 2024
KhronosGroup/glslang@9eef54b...3ee5f2f

$ git log 9eef54b..3ee5f2f --date=short --no-merges --format='%ad %ae %s'
2020-07-22 greg Update spirv-tools known-good to most recent stable
2020-07-19 vkushwaha Add changes for SPV_EXT_shader_atomic_float_add
2020-07-14 bclayton Limit visibility of symbols for internal libraries
2020-07-20 john SPV: Update to the latest SPIR-V headers.
2020-07-14 bclayton Deprecate InitializeDll functions
2020-07-14 bclayton Simplify PoolAlloc with use of thread_local.
2020-07-14 malcolm also search global variables assignment for live variables
2020-07-20 bclayton Drop support for VS2013
2020-07-20 bclayton Start glslang 11.0.0
2020-07-20 bclayton Finalize glslang 10.15.3847
2020-07-20 bclayton build_info: Fix parsing of versions with no flavor

Created with:
  roll-dep third_party/glslang

Roll third_party/spirv-headers/ 7f2ae11..979924c (1 commit)

KhronosGroup/SPIRV-Headers@7f2ae11...979924c

$ git log 7f2ae11..979924c --date=short --no-merges --format='%ad %ae %s'
2020-07-21 alanbaker Support SPV_KHR_terminate_invocation (KhronosGroup#163)

Created with:
  roll-dep third_party/spirv-headers

Roll third_party/spirv-tools/ c10d6ce..969f028 (18 commits)

KhronosGroup/SPIRV-Tools@c10d6ce...969f028

$ git log c10d6ce..969f028 --date=short --no-merges --format='%ad %ae %s'
2020-07-23 rharrison Change DEPS rolling script to point at external/ (KhronosGroup#3584)
2020-07-23 vasniktel spirv-fuzz: Create a helper in fuzzerutil to reuse function type (KhronosGroup#3572)
2020-07-23 vasniktel spirv-fuzz: Test usages of IdIsIrrelevant fact (KhronosGroup#3578)
2020-07-23 antonikarp spirv-fuzz: adds TransformationReplaceCopyMemoryWithLoadStore (KhronosGroup#3575)
2020-07-23 antonikarp spirv-fuzz: adds TransformationReplaceCopyObjectWithStoreLoad (KhronosGroup#3567)
2020-07-22 stevenperron Start SPIRV-Tools v2020.5
2020-07-22 stevenperron Finalize SPIRV-Tools v2020.4
2020-07-22 vasniktel spirv-fuzz: Fix usages of irrelevant constants (KhronosGroup#3566)
2020-07-22 stevenperron Update CHANGES
2020-07-22 alanbaker Support SPV_KHR_terminate_invocation (KhronosGroup#3568)
2020-07-22 stevenperron Sink pointer instructions in merge return (KhronosGroup#3569)
2020-07-21 greg Preserve OpenCL.DebugInfo.100 through elim-dead-code-aggressive (KhronosGroup#3542)
2020-07-21 vasniktel spirv-fuzz: TransformationReplaceParamsWithStruct (KhronosGroup#3455)
2020-07-21 38144211+vkushwaha-nv Add changes for SPV_EXT_shader_atomic_float (KhronosGroup#3562)
2020-07-21 vasniktel spirv-fuzz: Use irrelevant constants (KhronosGroup#3565)
2020-07-21 stefanomil spirv-fuzz: Extend TransformationRecordSynonymousConstants to allow composite constants (KhronosGroup#3537)
2020-07-21 vasniktel spirv-fuzz: Add is_irrelevant parameter (KhronosGroup#3563)
2020-07-20 vasniktel spirv-fuzz: Add IdIsIrrelevant fact (KhronosGroup#3561)

Created with:
  roll-dep third_party/spirv-tools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spirv-fuzz: Transformation to replace a subset of function parameters with a struct value

4 participants