Skip to content

Add newlines to two files to comply with POSIX standards#3242

Merged
alan-baker merged 1 commit intoKhronosGroup:masterfrom
aaronfranke:file-formatting
Mar 23, 2020
Merged

Add newlines to two files to comply with POSIX standards#3242
alan-baker merged 1 commit intoKhronosGroup:masterfrom
aaronfranke:file-formatting

Conversation

@aaronfranke
Copy link
Copy Markdown
Contributor

The POSIX standard for text files says that each text file should end with a newline, otherwise it is by definition not a text file. GitHub shows a warning when a file is committed without a terminating newline (see the "before" diffs of this PR), and GCC shows warnings when compiling files that don't end with newlines. See this SO question and this Unix SE question for more information.

There were only two files missing newlines, so I've added them.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 22, 2020

CLA assistant check
All committers have signed the CLA.

@alan-baker alan-baker merged commit 7f341ff into KhronosGroup:master Mar 23, 2020
@aaronfranke aaronfranke deleted the file-formatting branch March 23, 2020 17:44
dneto0 pushed a commit to dneto0/SPIRV-Tools that referenced this pull request Sep 14, 2024
* Rolling 5 dependencies

Roll third_party/glslang/ 4b2483e..1f0fcbe (9 commits)

KhronosGroup/glslang@4b2483e...1f0fcbe

$ git log 4b2483e..1f0fcbe --date=short --no-merges --format='%ad %ae %s'
2020-03-21 arnfranke Make file formatting comply with POSIX and Unix standards
2020-03-19 courtneygo Fix MSVC build issue - remove invalid character
2020-03-18 alele Re-add NV enums for raytracing to prevent build breaks.
2020-03-18 cepheus Fix KhronosGroup#2132: constant matrix constructor from single non-scalar argument
2020-03-18 cepheus Bump version (also fix line endings the grammar).
2020-03-17 dkoch update known_good
2020-03-17 dkoch Add support for GLSL_EXT_ray_tracing
2020-03-17 cepheus SPV headers: Bump up to the latest header.
2020-03-16 jbolz Forbid memoryBarrierAtomicCounter for Vulkan compiles

Roll third_party/googletest/ e588eb1ff..749148f1a (10 commits)

google/googletest@e588eb1...749148f

$ git log e588eb1ff..749148f1a --date=short --no-merges --format='%ad %ae %s'
2020-03-20 absl-team Googletest export
2020-03-17 absl-team Googletest export
2020-03-16 dmauro Googletest export
2020-03-13 absl-team Googletest export
2020-03-06 absl-team Googletest export
2020-03-03 absl-team Googletest export
2020-03-03 absl-team Googletest export
2020-03-11 romain.geissler Make sure IsATTY does not clobber errno.
2020-02-21 johan.mabille Fixed warnings
2020-01-29 krystian.kuzniarek remove a dead reference to the Autotools script

Roll third_party/spirv-cross/ 65aa0c35d..871c85d7f (4 commits)

KhronosGroup/SPIRV-Cross@65aa0c3...871c85d

$ git log 65aa0c35d..871c85d7f --date=short --no-merges --format='%ad %ae %s'
2020-03-19 post GLSL: Implement GL_EXT_shader_framebuffer_fetch.
2020-03-19 post Run format_all.sh.
2020-03-19 post GLSL/HLSL: Fix nonuniform qualifier for SSBO atomics.
2020-03-19 post GLSL/HLSL: Implement nonuniform qualifier for image atomics.

Roll third_party/spirv-headers/ a17e17e..f8bf11a (5 commits)

KhronosGroup/SPIRV-Headers@a17e17e...f8bf11a

$ git log a17e17e..f8bf11a --date=short --no-merges --format='%ad %ae %s'
2020-03-17 dkoch Add shadercalls scope
2020-03-03 ntorosda Added ray flags, primitive culling flags, queries
2020-03-17 cepheus Non-functional: Update header build to match Khronos spec. builder.
2020-02-14 alele Update headers for SPV_KHR_ray_tracing.
2020-01-01 xanto Also propagate SPIRV-Headers version to CMakeLists.txt

Roll third_party/spirv-tools/ 25ede1c..1c8bda3 (7 commits)

KhronosGroup/SPIRV-Tools@25ede1c...1c8bda3

$ git log 25ede1c..1c8bda3 --date=short --no-merges --format='%ad %ae %s'
2020-03-23 jaebaek Add data structure for DebugScope, DebugDeclare in spirv-opt (KhronosGroup#3183)
2020-03-23 ehsannas Whitelist SPV_KHR_ray_tracing (KhronosGroup#3241)
2020-03-23 arnfranke Make file formatting comply with POSIX standards (KhronosGroup#3242)
2020-03-19 dneto Add opt::Operand::AsCString and AsString (KhronosGroup#3240)
2020-03-20 lujiao Add RayQueryProvisionalKHR to opt types (KhronosGroup#3239)
2020-03-17 ehsannas Whitelist SPV_EXT_demote_to_helper_invocation for opt passes (KhronosGroup#3236)
2020-03-17 dgkoch Add support for KHR_ray_{query,tracing} extensions (KhronosGroup#3235)

Created with:
  roll-dep third_party/effcee third_party/glslang third_party/googletest third_party/re2 third_party/spirv-cross third_party/spirv-headers third_party/spirv-tools

* Updated expectations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants