Merging two ValidateMemoryScope implementations#2132
Merged
zoddicus merged 1 commit intoKhronosGroup:masterfrom Nov 29, 2018
zoddicus:issue2125PartB
Merged
Merging two ValidateMemoryScope implementations#2132zoddicus merged 1 commit intoKhronosGroup:masterfrom zoddicus:issue2125PartB
zoddicus merged 1 commit intoKhronosGroup:masterfrom
zoddicus:issue2125PartB
Conversation
alan-baker
approved these changes
Nov 29, 2018
| const SpvOp opcode = inst->opcode(); | ||
| bool is_int32 = false, is_const_int32 = false; | ||
| uint32_t value = 0; | ||
| std::tie(is_int32, is_const_int32, value) = _.EvalInt32IfConst(scope); |
Contributor
There was a problem hiding this comment.
EvalInt32IfConst returns that the value is constant for OpSpecConstant* opcodes. In that case, the value it returns is not reliable. In the worst case we reinterpret an opcode from an OpSpecConstantOp as a value. In other cases we interpret the default value as the real value. Both of these are wrong. I've filed #2133 to address this, since your PR doesn't make it any worse.
dneto0
pushed a commit
to dneto0/SPIRV-Tools
that referenced
this pull request
Sep 14, 2024
* Rolling 5 dependencies Roll third_party/glslang/ 4b2483e..1f0fcbe (9 commits) KhronosGroup/glslang@4b2483e...1f0fcbe $ git log 4b2483e..1f0fcbe --date=short --no-merges --format='%ad %ae %s' 2020-03-21 arnfranke Make file formatting comply with POSIX and Unix standards 2020-03-19 courtneygo Fix MSVC build issue - remove invalid character 2020-03-18 alele Re-add NV enums for raytracing to prevent build breaks. 2020-03-18 cepheus Fix KhronosGroup#2132: constant matrix constructor from single non-scalar argument 2020-03-18 cepheus Bump version (also fix line endings the grammar). 2020-03-17 dkoch update known_good 2020-03-17 dkoch Add support for GLSL_EXT_ray_tracing 2020-03-17 cepheus SPV headers: Bump up to the latest header. 2020-03-16 jbolz Forbid memoryBarrierAtomicCounter for Vulkan compiles Roll third_party/googletest/ e588eb1ff..749148f1a (10 commits) google/googletest@e588eb1...749148f $ git log e588eb1ff..749148f1a --date=short --no-merges --format='%ad %ae %s' 2020-03-20 absl-team Googletest export 2020-03-17 absl-team Googletest export 2020-03-16 dmauro Googletest export 2020-03-13 absl-team Googletest export 2020-03-06 absl-team Googletest export 2020-03-03 absl-team Googletest export 2020-03-03 absl-team Googletest export 2020-03-11 romain.geissler Make sure IsATTY does not clobber errno. 2020-02-21 johan.mabille Fixed warnings 2020-01-29 krystian.kuzniarek remove a dead reference to the Autotools script Roll third_party/spirv-cross/ 65aa0c35d..871c85d7f (4 commits) KhronosGroup/SPIRV-Cross@65aa0c3...871c85d $ git log 65aa0c35d..871c85d7f --date=short --no-merges --format='%ad %ae %s' 2020-03-19 post GLSL: Implement GL_EXT_shader_framebuffer_fetch. 2020-03-19 post Run format_all.sh. 2020-03-19 post GLSL/HLSL: Fix nonuniform qualifier for SSBO atomics. 2020-03-19 post GLSL/HLSL: Implement nonuniform qualifier for image atomics. Roll third_party/spirv-headers/ a17e17e..f8bf11a (5 commits) KhronosGroup/SPIRV-Headers@a17e17e...f8bf11a $ git log a17e17e..f8bf11a --date=short --no-merges --format='%ad %ae %s' 2020-03-17 dkoch Add shadercalls scope 2020-03-03 ntorosda Added ray flags, primitive culling flags, queries 2020-03-17 cepheus Non-functional: Update header build to match Khronos spec. builder. 2020-02-14 alele Update headers for SPV_KHR_ray_tracing. 2020-01-01 xanto Also propagate SPIRV-Headers version to CMakeLists.txt Roll third_party/spirv-tools/ 25ede1c..1c8bda3 (7 commits) KhronosGroup/SPIRV-Tools@25ede1c...1c8bda3 $ git log 25ede1c..1c8bda3 --date=short --no-merges --format='%ad %ae %s' 2020-03-23 jaebaek Add data structure for DebugScope, DebugDeclare in spirv-opt (KhronosGroup#3183) 2020-03-23 ehsannas Whitelist SPV_KHR_ray_tracing (KhronosGroup#3241) 2020-03-23 arnfranke Make file formatting comply with POSIX standards (KhronosGroup#3242) 2020-03-19 dneto Add opt::Operand::AsCString and AsString (KhronosGroup#3240) 2020-03-20 lujiao Add RayQueryProvisionalKHR to opt types (KhronosGroup#3239) 2020-03-17 ehsannas Whitelist SPV_EXT_demote_to_helper_invocation for opt passes (KhronosGroup#3236) 2020-03-17 dgkoch Add support for KHR_ray_{query,tracing} extensions (KhronosGroup#3235) Created with: roll-dep third_party/effcee third_party/glslang third_party/googletest third_party/re2 third_party/spirv-cross third_party/spirv-headers third_party/spirv-tools * Updated expectations
dneto0
pushed a commit
to dneto0/SPIRV-Tools
that referenced
this pull request
Sep 14, 2024
Roll third_party/glslang/ 1f0fcbe..8e26c5f (26 commits) $ git log 1f0fcbe..8e26c5f --date=short --no-merges --format='%ad %ae %s' 2020-03-25 neslisah.torosdagli@amd.com switch format update 2020-03-24 neslisah.torosdagli@amd.com copyright notice changes removed from unchanged files 2020-03-24 neslisah.torosdagli@amd.com copyright notice changes removed from unchanged files 2020-03-24 neslisah.torosdagli@amd.com copyright notice changes removed from unchanged files 2020-03-24 neslisah.torosdagli@amd.com spirv.hpp reverted to commit f368dcb 2020-03-24 neslisah.torosdagli@amd.com .travis updated to origin, rayQueryCheck removed 2020-03-23 neslisah.torosdagli@amd.com const rayFlag defs used in the test cases in stead of numerical values 2020-03-23 neslisah.torosdagli@amd.com compute and fragment shader test_cases added for rayQuery 2020-03-23 neslisah.torosdagli@amd.com rayQuery test cases added 2020-03-23 neslisah.torosdagli@amd.com rayQueryEXT function parameter 2020-03-23 neslisah.torosdagli@amd.com rayQueryEXT assignment is allowed. 2020-03-23 neslisah.torosdagli@amd.com test names updated 2020-03-23 kainino@chromium.org update README 2020-03-23 kainino@chromium.org Fix build on CMake 2.8, and fix Web build 2020-03-23 neslisah.torosdagli@amd.com wait time increased for the install 2020-03-23 neslisah.torosdagli@amd.com rayQuery test cases disabled 2020-03-20 neslisah.torosdagli@amd.com GL_EXT_ray_query glslang updates, and test cases added. 2020-03-19 neslisah.torosdagli@amd.com comment update, rayQueryEXT is writable, readonly check removed. 2020-03-19 ntorosda@amd.com GL_EXT_ray_query updates 2020-03-18 cepheus@frii.com Fix KhronosGroup#2132: constant matrix constructor from single non-scalar argument 2020-03-19 neslisah.torosdagli@amd.com comment update, rayQueryEXT is writable, readonly check removed. 2020-03-19 ntorosda@amd.com GL_EXT_ray_query updates 2020-03-18 cepheus@frii.com Fix KhronosGroup#2132: constant matrix constructor from single non-scalar argument 2020-03-19 neslisah.torosdagli@amd.com comment update, rayQueryEXT is writable, readonly check removed. 2020-03-19 neslisah.torosdagli@amd.com GL_EXT_ray_query updates 2020-03-19 ntorosda@amd.com GL_EXT_ray_query updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2125