Skip to content

Add properties parameter to all command-buffer commands#2050

Closed
EwanC wants to merge 2 commits intoKhronosGroup:mainfrom
EwanC:ewan/command_properties
Closed

Add properties parameter to all command-buffer commands#2050
EwanC wants to merge 2 commits intoKhronosGroup:mainfrom
EwanC:ewan/command_properties

Conversation

@EwanC
Copy link
Copy Markdown
Contributor

@EwanC EwanC commented Aug 15, 2024

Make changes to reflect OpenCL-Docs change KhronosGroup/OpenCL-Docs#1215 and requires header change KhronosGroup/OpenCL-Headers#260 to use preprocessor path with extra parameters

Used CL_DEVICE_EXTENSIONS_WITH_VERSION runtime check and skipped testing when a device doesn't support required versions.

Tested using OCK updated with this API change uxlfoundation/oneapi-construction-kit#519

Ewan Crawford added 2 commits September 5, 2024 16:53
Make changes to reflect OpenCL-Docs change KhronosGroup/OpenCL-Docs#1215
and requires header change KhronosGroup/OpenCL-Headers#260
to use preprocessor path with extra parameters
@EwanC EwanC force-pushed the ewan/command_properties branch from 8eb259b to 76d1749 Compare September 5, 2024 16:32
@EwanC EwanC marked this pull request as ready for review September 5, 2024 16:35
bashbaug added a commit that referenced this pull request Sep 6, 2024
This is an update to #2050, with updates from the main branch.

---------

Co-authored-by: Ewan Crawford <ewan@codeplay.com>
@bashbaug
Copy link
Copy Markdown
Contributor

bashbaug commented Sep 6, 2024

Merged with #2072, closing.

@bashbaug bashbaug closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants