Conversation
…r and clicking in the combobox where the mouse button capture textbox is.
Collaborator
Author
|
Along with this plugin system a lot of refactoring is happening. I'll track bug fixes, features and breaking changes in this post. ⚠ Breaking Changes
New features
Bugs
Known Issues
|
… result of ExecuteForScript not being able to put on Lua Stack
…ote reference tracking + Basic Midi script functionality
This was referenced Oct 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to include midi functionality through DryWetMIDI, but that got me thinking: I'm creeping in so many features and dependencies, perhaps some users don't want all that functionality. Or perhaps they want custom features that I'm not adding. I feel plugins would be a good solution to this, besides being fun to implement.
Key2Joy.Plugin.Midiin this branch shows an early example (e.g: Key2Joy.Plugin.Midi /Mapping/Actions/GetHelloWorldAction.cs). I hope to expand it to a plugin that will add Midi Controller trigger and some Midi writing action capabilities.Plugins would add:
Some negatives:
PR Checklist
AppDomain)Key2Joy.Plugin.HelloWorld)Key2Joy.Plugin.Ffmpeg) while tackling AnimationFromImagesAction fails due to ffprobe.exe missing #36BuildMarkdownDocsalso generate plugin markdownsPostponed
I've crossed these off the original PR checklist. I'm postponing them until I've fixed most bugs people are currently encountering:Plugin <- PluginHost -> Key2JoyinteractionKey2Joy.Plugin.Midi)Moved one of the scripting languages to a plugin (to serve as an example and test case for complex plugins)These postponed points have been moved to #51 and #52 for tracking)