Skip to content

Document \def doesn't support delimiters (#2288)#2289

Merged
ronkok merged 1 commit intoKaTeX:masterfrom
edemaine:doc-no-delimiters
Jul 9, 2020
Merged

Document \def doesn't support delimiters (#2288)#2289
ronkok merged 1 commit intoKaTeX:masterfrom
edemaine:doc-no-delimiters

Conversation

@edemaine
Copy link
Member

@edemaine edemaine commented Jul 9, 2020

\def has never supported delimiters, but I don't think we mention it anywhere, which recently led to #2288. Added mention to function support documentation.

See https://deploy-preview-2289--katex.netlify.app/docs/next/supported.html#macros

@edemaine edemaine mentioned this pull request Jul 9, 2020
12 tasks
Copy link
Collaborator

@ronkok ronkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ronkok ronkok merged commit f96fba6 into KaTeX:master Jul 9, 2020
@edemaine
Copy link
Member Author

edemaine commented Jul 9, 2020

Thanks @ronkok!

ylemkimon added a commit that referenced this pull request Aug 31, 2020
ylemkimon added a commit that referenced this pull request Sep 6, 2020
* Improve macro argument parsing

* Make \above a primitive command

* Fix screenshotter data

* Normalize argument where necessary

* Improve argument location info

* Update comments

* Minor refactor

* Modularize group parsers

* Allow braced and blank size argument

for non-strict mode and \genfrac, respectively.

* Minor refactor & update comments

* Remove raw option in parseStringGroup

* Update tests

* Fix { delimited parameter

* Update tests

* Update tests

* Normalize argument in \genfrac

* Update tests

* Consume space before scanning an optional argument

* Fix \\, \newline, and \cr behavior

* Fix flow error

* Update comments

* Remove unnecessary mode switching

Parser mode affects neither fetch nor consume.

* Allow single (active) character macro

* Add function property `primitive`

* Set \mathchoice and \*style primitive

* Separate size-related improvements out to #2139

* Fix flow error

* Update screenshots

* Update demo example

* Add a migration guide

* Fix capitalization

* Make a primitive function unexpandable

* Update screenshots

* Update screenshots

* Revert "Document \def doesn't support delimiters (#2288) (#2289)"

This reverts commit f96fba6.

* Update comments, errors, and tests

* Update screenshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants