Conversation
ylemkimon
added a commit
that referenced
this pull request
Oct 28, 2019
- Rename size to dimen - Use parseDimen - New ArgType `dimen_primitive` and `dimen_or_blank`
Member
|
@ylemkimon the tests are passing now. Is there more that you wanted to do with this PR or is it ready for review now? |
Codecov Report
@@ Coverage Diff @@
## master #2139 +/- ##
==========================================
- Coverage 93.81% 91.80% -2.02%
==========================================
Files 84 85 +1
Lines 6128 6366 +238
Branches 1260 1349 +89
==========================================
+ Hits 5749 5844 +95
- Misses 348 467 +119
- Partials 31 55 +24
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
ylemkimon
added a commit
that referenced
this pull request
Sep 6, 2020
* Improve macro argument parsing
* Make \above a primitive command
* Fix screenshotter data
* Normalize argument where necessary
* Improve argument location info
* Update comments
* Minor refactor
* Modularize group parsers
* Allow braced and blank size argument
for non-strict mode and \genfrac, respectively.
* Minor refactor & update comments
* Remove raw option in parseStringGroup
* Update tests
* Fix { delimited parameter
* Update tests
* Update tests
* Normalize argument in \genfrac
* Update tests
* Consume space before scanning an optional argument
* Fix \\, \newline, and \cr behavior
* Fix flow error
* Update comments
* Remove unnecessary mode switching
Parser mode affects neither fetch nor consume.
* Allow single (active) character macro
* Add function property `primitive`
* Set \mathchoice and \*style primitive
* Separate size-related improvements out to #2139
* Fix flow error
* Update screenshots
* Update demo example
* Add a migration guide
* Fix capitalization
* Make a primitive function unexpandable
* Update screenshots
* Update screenshots
* Revert "Document \def doesn't support delimiters (#2288) (#2289)"
This reverts commit f96fba6.
* Update comments, errors, and tests
* Update screenshots
This was referenced Sep 30, 2020
9a985be to
0ef8921
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Size argument
Primitive commands, such as
\aboveand kern commands don't not allow braced size argument. This PR introduces a new argument typesize_primitiveto parse it. For backward compatibility, braced size arguments are allowed in non-strict mode. (BREAKING CHANGE) Fixes #1936.Furthermore, a blank size argument was allowed for most commands. This PR introduces a new argument type
size_or_blank, which allows a blank argument, and use it only for\genfrac.[2]