Update Ptr/Ref and errno checking for roots and multiroots#40
Merged
jiahao merged 8 commits intoJuliaMath:masterfrom Jan 30, 2016
Merged
Update Ptr/Ref and errno checking for roots and multiroots#40jiahao merged 8 commits intoJuliaMath:masterfrom
jiahao merged 8 commits intoJuliaMath:masterfrom
Conversation
This commit reverts a number of previous changes in the roots and multiroots functionality where Ptr had been changed to Ref, and also updates the checking of the errno to allow for continuing execution in the case where the returned value is GSL_SUCCESS or GSL_CONTINUE.
Contributor
Author
|
Linux tests are now failing for the same reason as #39. |
This commit adds a BinDeps.debug statement in an attempt to debug the joinpath issues present in the existing Travis testing seen with prior commits. These additions will be reverted once the cause of the current build error is determined. In an attempt to reproduce the joinpath error locally, Tony was not able to reproduce the behavior on Ubuntu, so this commit is an attempt to debug within Travis itself.
jiahao
added a commit
that referenced
this pull request
Jan 30, 2016
Update Ptr/Ref and errno checking for roots and multiroots
Collaborator
|
Thanks! |
Collaborator
|
I took out the debug commits. Would be good to have some simple tests of these functions. |
AndyGreenwell
added a commit
to AndyGreenwell/GSL.jl
that referenced
this pull request
Feb 2, 2016
This commit makes the same changes to 35_4_Iteration.jl that were made to _35_4_Iteration.jl in JuliaMath#40, harmonizing the underscore and no underscore versions of these files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.