Skip to content

Fix incorrect use of aliases keyword argument #39

Merged
jiahao merged 1 commit intoJuliaMath:masterfrom
tkelman:patch-1
Jan 31, 2016
Merged

Fix incorrect use of aliases keyword argument #39
jiahao merged 1 commit intoJuliaMath:masterfrom
tkelman:patch-1

Conversation

@tkelman
Copy link
Copy Markdown
Contributor

@tkelman tkelman commented Dec 6, 2015

I think you might need this to avoid going to a docker container build on linux that can't do sudo

@tkelman
Copy link
Copy Markdown
Contributor Author

tkelman commented Dec 6, 2015

deps.jl issue?

=================================[ ERROR: GSL ]=================================

LoadError: MethodError: `joinpath` has no method matching joinpath(::UTF8String, ::Char)
Closest candidates are:
  joinpath(::AbstractString)
  joinpath(::AbstractString, !Matched::AbstractString)
  joinpath(::AbstractString, !Matched::AbstractString, !Matched::AbstractString...)
while loading /home/travis/.julia/v0.4/GSL/deps/build.jl, in expression starting on line 30

@jiahao
Copy link
Copy Markdown
Collaborator

jiahao commented Jan 30, 2016

Thanks for looking into the Linux failures. It works perfectly on my Linux machine.

I have isolated the problem to the @BinDeps.install line. Somewhere inside, it is calling joinpath and failing miserably to join a UTF8String with a Char.

I have been unable to determine which of the many calls to joinpath in BinDeps generates this error, or why Travis's setup would cause this to happen. I suspect that the logic in BinDeps may assume that directory subpaths are not 1 character long.

Until this issue is resolved, all I can do is disable testing on Linux until further notice.

jiahao added a commit that referenced this pull request Jan 30, 2016
Travis's Linux setup causes an inscrutable error thrown from deep within
BinDeps. Ref #39
jiahao added a commit that referenced this pull request Jan 30, 2016
Travis's Linux setup throws an inscrutable error. Ref #39
jiahao added a commit that referenced this pull request Jan 30, 2016
Travis's Linux setup throws an inscrutable error. Ref #39
@tkelman
Copy link
Copy Markdown
Contributor Author

tkelman commented Jan 30, 2016

This looks like you've somehow triggered a very bad BinDeps bug. I do think we should do our best to pinpoint the cause and try to fix it in BinDeps.

otherwise BinDeps was trying to iterate over the characters of the
single alias string, which led to joinpath errors
@tkelman
Copy link
Copy Markdown
Contributor Author

tkelman commented Jan 31, 2016

@jiahao I figured it out (see master...tkelman:travistest and JuliaPackaging/BinDeps.jl@master...tkelman:debug) - you were I was using the aliases keyword argument incorrectly, you're supposed to provide an array of strings, not just a single alias string. The error message was inscrutable and awful to debug, so maybe BinDeps could do something smarter with a warning if it detects this mistake.

@tkelman tkelman changed the title add sudo: required on travis Fix incorrect use of aliases keyword argument Jan 31, 2016
@tkelman
Copy link
Copy Markdown
Contributor Author

tkelman commented Jan 31, 2016

Oh, wait, I added that alias. My bad, sorry! 9a9ce85

also cc @AndyGreenwell

@tkelman
Copy link
Copy Markdown
Contributor Author

tkelman commented Jan 31, 2016

I'm still not entirely sure why the apt-get provider isn't working here, but at least the source build works after fixing the alias issue.

tkelman added a commit to JuliaPackaging/BinDeps.jl that referenced this pull request Jan 31, 2016
to avoid the ```MethodError: `joinpath` has no method matching joinpath(::UTF8String, ::Char)```
seen at JuliaMath/GSL.jl#39
@jiahao
Copy link
Copy Markdown
Collaborator

jiahao commented Jan 31, 2016

Oh wow, talk about subtle. Thanks for tracking it down!

@jiahao
Copy link
Copy Markdown
Collaborator

jiahao commented Jan 31, 2016

Merging to reenable Linux tests

jiahao added a commit that referenced this pull request Jan 31, 2016
Fix incorrect use of aliases keyword argument
@jiahao jiahao merged commit 449bc3b into JuliaMath:master Jan 31, 2016
@tkelman tkelman deleted the patch-1 branch January 31, 2016 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants