Revert "Avoid allocations in views of views (#53231)"#57044
Merged
oscardssmith merged 1 commit intomasterfrom Jan 14, 2025
Merged
Revert "Avoid allocations in views of views (#53231)"#57044oscardssmith merged 1 commit intomasterfrom
oscardssmith merged 1 commit intomasterfrom
Conversation
This reverts commit 2bd4cf8.
jishnub
approved these changes
Jan 14, 2025
Member
jishnub
left a comment
There was a problem hiding this comment.
I agree, this needs to be rethought.
KristofferC
added a commit
that referenced
this pull request
Jan 14, 2025
This reverts commit 2bd4cf8. (#53231) The reason for this revert is that it caused exponential blowup of types in iterated views causing some packages to simply freeze when doing something that worked ok in 1.10. In my opinion, the perf gain from the PR is not outweighed by the "risk" of hitting this compilation blowup case. Fixes #56760. Co-authored-by: KristofferC <kristoffer.carlsson@juliacomputing.com> (cherry picked from commit b23f557)
Zentrik
referenced
this pull request
Feb 8, 2025
Allow for more spaces between the "Total" and "Time" columns, in case tests take occasionally longer than usual. Fix #57095.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 2bd4cf8. (#53231)
The reason for this revert is that it caused exponential blowup of types in iterated views causing some packages to simply freeze when doing something that worked ok in 1.10.
In my opinion, the perf gain from the PR is not outweighed by the "risk" of hitting this compilation blowup case.
Fixes #56760.