Skip to content

[Test] Improve regex matching expected test summaries#57096

Merged
giordano merged 1 commit intoJuliaLang:masterfrom
giordano:mg/test-regex
Jan 18, 2025
Merged

[Test] Improve regex matching expected test summaries#57096
giordano merged 1 commit intoJuliaLang:masterfrom
giordano:mg/test-regex

Conversation

@giordano
Copy link
Copy Markdown
Member

@giordano giordano commented Jan 18, 2025

Allow for more spaces between "Total" and "Time" columns, in case tests take occasionally longer than usual.

This would make the failed test in #57095 pass:

julia> occursin(r"Test Summary: \| Pass  Fail  Total +Time
       Foo Tests     \|    2     2      4  \s*\d*\.\ds
         Animals     \|    1     1      2  \s*\d*\.\ds
           Felines   \|    1            1  \s*\d*\.\ds
           Canines   \|          1      1  \s*\d*\.\ds
         Arrays      \|    1     1      2  \s*\d*\.\ds
       ", "Canines: Test Failed at none:12\n  Expression: foo(\"dog\") == 11\n   Evaluated: 9 == 11\n\nStacktrace:\n [1] top-level scope\n   @ none:7\n [2] macro expansion\n   @ /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-x64-5.0/build/default-macmini-x64-5-0/julialang/julia-master/julia-cd027888a7/share/julia/stdlib/v1.12/Test/src/Test.jl:1764 [inlined]\n [3] macro expansion\n   @ none:8 [inlined]\n [4] macro expansion\n   @ /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-x64-5.0/build/default-macmini-x64-5-0/julialang/julia-master/julia-cd027888a7/share/julia/stdlib/v1.12/Test/src/Test.jl:1764 [inlined]\n [5] macro expansion\n   @ none:12 [inlined]\n [6] macro expansion\n   @ /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-x64-5.0/build/default-macmini-x64-5-0/julialang/julia-master/julia-cd027888a7/share/julia/stdlib/v1.12/Test/src/Test.jl:1764 [inlined]\n [7] macro expansion\n   @ none:12 [inlined]\n [8] macro expansion\n   @ /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-x64-5.0/build/default-macmini-x64-5-0/julialang/julia-master/julia-cd027888a7/share/julia/stdlib/v1.12/Test/src/Test.jl:679 [inlined]\nArrays: Test Failed at none:17\n  Expression: foo(fill(1.0, 4)) == 15\n   Evaluated: 16 == 15\n\nStacktrace:\n [1] top-level scope\n   @ none:7\n [2] macro expansion\n   @ /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-x64-5.0/build/default-macmini-x64-5-0/julialang/julia-master/julia-cd027888a7/share/julia/stdlib/v1.12/Test/src/Test.jl:1764 [inlined]\n [3] macro expansion\n   @ none:16 [inlined]\n [4] macro expansion\n   @ /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-x64-5.0/build/default-macmini-x64-5-0/julialang/julia-master/julia-cd027888a7/share/julia/stdlib/v1.12/Test/src/Test.jl:1764 [inlined]\n [5] macro expansion\n   @ none:17 [inlined]\n [6] macro expansion\n   @ /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-x64-5.0/build/default-macmini-x64-5-0/julialang/julia-master/julia-cd027888a7/share/julia/stdlib/v1.12/Test/src/Test.jl:679 [inlined]\nTest Summary: | Pass  Fail  Total   Time\nFoo Tests     |    2     2      4  10.2s\n  Animals     |    1     1      2  10.0s\n    Felines   |    1            1   0.0s\n    Canines   |          1      1  10.0s\n  Arrays      |    1     1      2   0.1s\nRNG of the outermost testset: Random.Xoshiro(0xe8d7b24b2f690da2, 0x354660fd679bcb5d, 0xb33a21adffe3f15b, 0x95b5454a71f564bf, 0x20c262b28365e7b9)\n")
true

Fix #57095.

@giordano
[Test] Improve regex matching expected test summaries
0fed408 
Allow for more spaces between "Total" and "Time" columns, in case tests take
occasionally longer than usual.
@giordano giordano added test This change adds or pertains to unit tests testsystem The unit testing framework and Test stdlib labels Jan 18, 2025
@giordano giordano merged commit cbc47c9 into JuliaLang:master Jan 18, 2025
@giordano giordano deleted the mg/test-regex branch January 18, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

test This change adds or pertains to unit tests testsystem The unit testing framework and Test stdlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Broken test in Test stdlib

1 participant

@giordano