Skip to content

Remove outdated discussion about externally changing module bindings#53170

Merged
vtjnash merged 1 commit intoJuliaLang:masterfrom
goerz:patch-1
Feb 7, 2024
Merged

Remove outdated discussion about externally changing module bindings#53170
vtjnash merged 1 commit intoJuliaLang:masterfrom
goerz:patch-1

Conversation

@goerz
Copy link
Copy Markdown
Contributor

@goerz goerz commented Feb 3, 2024

As of Julia 1.9, bindings in modules can be changed directly.

See https://discourse.julialang.org/t/clarify-the-documentation-about-modifying-module-variables/109668/3

@inkydragon
Copy link
Copy Markdown
Member

Need backport to 1.9, 1.10 ?

@inkydragon inkydragon added the docs This change adds or pertains to documentation label Feb 3, 2024
@vtjnash vtjnash merged commit 736eeda into JuliaLang:master Feb 7, 2024
@fingolfin fingolfin added the backport 1.10 Change should be backported to the 1.10 release label Feb 7, 2024
@KristofferC KristofferC mentioned this pull request Feb 20, 2024
19 tasks
KristofferC pushed a commit that referenced this pull request Feb 26, 2024
KristofferC pushed a commit that referenced this pull request Feb 26, 2024
KristofferC added a commit that referenced this pull request Feb 27, 2024
Backported PRs:
- [x] #53205 <!-- Profile: add notes to `print()` docs -->
- [x] #53170 <!-- Remove outdated discussion about externally changing
module bindings -->
- [x] #53228 <!-- SubArray: avoid invalid elimination of singleton
indices -->
- [x] #51361 <!-- code_warntype docs: more neutral reference to
@code_warntype -->
- [x] #50480 <!-- Document --heap-size-hint in Command-line Interface
-->
- [x] #53301 <!-- Fix typo in `Sys.total_memory` docstring. -->
- [x] #53354 <!-- fix code coverage bug in tail position and `else` -->
- [x] #53388 <!-- Fix documentation: thread pool of main thread -->
- [x] #53429 <!-- Subtype: skip slow-path in `local_∀_∃_subtype` if
inputs contain no ∃ typevar. -->
- [x] #53437 <!-- Add debug variant of loader_trampolines.o -->

Need manual backport:
- [ ] #52505 <!-- fix alignment of emit_unbox_store copy -->
- [ ] #53373 <!-- fix sysimage-native-code=no option with pkgimages -->
- [ ] #53439 <!-- staticdata: fix assert from partially disabled native
code -->

Contains multiple commits, manual intervention needed:
- [ ] #52913 <!-- Added docstring for Artifacts.jl -->
- [ ] #53218 <!-- Fix interpreter_exec.jl test -->

Non-merged PRs with backport label:
- [ ] #53424 <!-- yet more atomics & cache-line fixes on work-stealing
queue -->
- [ ] #53125 <!-- coverage: count coverage where explicitly requested by
inference only -->
- [ ] #52694 <!-- Reinstate similar for AbstractQ for backward
compatibility -->
- [ ] #51479 <!-- prevent code loading from lookin in the versioned
environment when building Julia -->
@KristofferC KristofferC removed the backport 1.10 Change should be backported to the 1.10 release label Mar 12, 2024
Drvi pushed a commit to RelationalAI/julia that referenced this pull request Jun 7, 2024
@KristofferC KristofferC mentioned this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs This change adds or pertains to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants