Conversation
aviatesk
approved these changes
Oct 4, 2023
Member
aviatesk
left a comment
There was a problem hiding this comment.
Just for future reference, could you explain the rationale behind adding @nospecialize in #36596, even though we're now considering its removal? As for the use of @noinline here, the reasoning can be found in this comment.
Member
Author
|
I assume we added it just because it doesn't seem necessary to re-compile the function for every length of tuple --- if the tuples are heap allocated. But now that we can stack allocate them there is some value to it. |
KristofferC
pushed a commit
that referenced
this pull request
Oct 10, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to be the right combination of annotations to fix both #50562 and an inference regression in PropertyDicts.jl on the 1.10 release branch. When backported the
@noinlineshould be restored for 1.10.