some minor code quality / correctness improvements#36596
Merged
Conversation
Member
|
Something in 5e86746 is going haywire --- 4x longer to precompile Plots, +5% sysimg. |
Member
Author
|
Ah, I see what happened. The new lazy-ambiguity logic assumes that subtyping is transitive over specificity, and I accidentally formed a contradiction of that premise on the definition of And I wasn't checking for this case, so in the results, it appeared that |
We need to run the PassManager passes before we destroy important metadata.
These functions were changed in #28380, but their tfuncs were not changed at that time also.
We were accidentally widening Const(false) here to Bool if either argument was a Slot (such as an Argument). We don't want to do that!
remove unused type parameters from some functions, add some useful ones to others, and remove the fallback `==` method in Core.Compiler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Digging around at a few things that seemed to show up re-compiled often